[jira] [Commented] (MESOS-3023) Factoring out the pattern for URL generation

["Bernd Mathiske (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651586#comment-14651586 ] 

Bernd Mathiske commented on MESOS-3023:
---------------------------------------

This latest patch first factors out the URL generation, then inserts white space:

commit 9c905880abc02e064f0430afab12afa6073549c8
Author: Artem Harutyunyan <ar...@mesosphere.io>
Date:   Mon Aug 3 10:22:15 2015 +0200

    Factored out the pattern for URL generation in (another) fetcher test.
    
    Review: https://reviews.apache.org/r/36946

> Factoring out the pattern for URL generation 
> ---------------------------------------------
>
>                 Key: MESOS-3023
>                 URL: https://issues.apache.org/jira/browse/MESOS-3023
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Artem Harutyunyan
>            Assignee: Klaus Ma
>            Priority: Minor
>              Labels: beginner, mesosphere, newbie
>
> fetcher_test.cpp uses the following code for generating URLs:
> string url = "http://" + net::getHostname(process.self().address.ip).get() + ":" + stringify(process.self().address.port) + "/" + process.self().id
> it would be good to isolate that code in a function, and replace the code above with something like:
> string url = "http://" + endpoint_url(process, "uri_test");



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)