You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Bharath Mundlapudi (JIRA)" <ji...@apache.org> on 2011/06/13 19:24:51 UTC
[jira] [Created] (HADOOP-7385) Remove
StringUtils.stringifyException(ie) in logger functions
Remove StringUtils.stringifyException(ie) in logger functions
-------------------------------------------------------------
Key: HADOOP-7385
URL: https://issues.apache.org/jira/browse/HADOOP-7385
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
Priority: Minor
Fix For: 0.23.0
Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
ie.:
Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7385) Remove
StringUtils.stringifyException(ie) in logger functions
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HADOOP-7385:
---------------------------------
Status: Patch Available (was: Open)
> Remove StringUtils.stringifyException(ie) in logger functions
> -------------------------------------------------------------
>
> Key: HADOOP-7385
> URL: https://issues.apache.org/jira/browse/HADOOP-7385
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7385-1.patch
>
>
> Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
> ie.:
> Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7385) Remove
StringUtils.stringifyException(ie) in logger functions
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054167#comment-13054167 ]
Tanping Wang commented on HADOOP-7385:
--------------------------------------
+1 on the patch.
> Remove StringUtils.stringifyException(ie) in logger functions
> -------------------------------------------------------------
>
> Key: HADOOP-7385
> URL: https://issues.apache.org/jira/browse/HADOOP-7385
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7385-1.patch
>
>
> Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
> ie.:
> Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7385) Remove
StringUtils.stringifyException(ie) in logger functions
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057158#comment-13057158 ]
Hudson commented on HADOOP-7385:
--------------------------------
Integrated in Hadoop-Common-trunk #732 (See [https://builds.apache.org/job/Hadoop-Common-trunk/732/])
> Remove StringUtils.stringifyException(ie) in logger functions
> -------------------------------------------------------------
>
> Key: HADOOP-7385
> URL: https://issues.apache.org/jira/browse/HADOOP-7385
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7385-1.patch
>
>
> Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
> ie.:
> Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7385) Remove
StringUtils.stringifyException(ie) in logger functions
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057097#comment-13057097 ]
Hudson commented on HADOOP-7385:
--------------------------------
Integrated in Hadoop-Common-trunk-maven #43 (See [https://builds.apache.org/job/Hadoop-Common-trunk-maven/43/])
> Remove StringUtils.stringifyException(ie) in logger functions
> -------------------------------------------------------------
>
> Key: HADOOP-7385
> URL: https://issues.apache.org/jira/browse/HADOOP-7385
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7385-1.patch
>
>
> Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
> ie.:
> Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7385) Remove
StringUtils.stringifyException(ie) in logger functions
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HADOOP-7385:
---------------------------------
Hadoop Flags: [Reviewed]
> Remove StringUtils.stringifyException(ie) in logger functions
> -------------------------------------------------------------
>
> Key: HADOOP-7385
> URL: https://issues.apache.org/jira/browse/HADOOP-7385
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7385-1.patch
>
>
> Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
> ie.:
> Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7385) Remove
StringUtils.stringifyException(ie) in logger functions
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054185#comment-13054185 ]
Tanping Wang commented on HADOOP-7385:
--------------------------------------
Just committed the patch. Thanks to Bharath Mundlapudi!
> Remove StringUtils.stringifyException(ie) in logger functions
> -------------------------------------------------------------
>
> Key: HADOOP-7385
> URL: https://issues.apache.org/jira/browse/HADOOP-7385
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7385-1.patch
>
>
> Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
> ie.:
> Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7385) Remove
StringUtils.stringifyException(ie) in logger functions
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057648#comment-13057648 ]
Hudson commented on HADOOP-7385:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #668 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/668/])
> Remove StringUtils.stringifyException(ie) in logger functions
> -------------------------------------------------------------
>
> Key: HADOOP-7385
> URL: https://issues.apache.org/jira/browse/HADOOP-7385
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7385-1.patch
>
>
> Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
> ie.:
> Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7385) Remove
StringUtils.stringifyException(ie) in logger functions
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HADOOP-7385:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Remove StringUtils.stringifyException(ie) in logger functions
> -------------------------------------------------------------
>
> Key: HADOOP-7385
> URL: https://issues.apache.org/jira/browse/HADOOP-7385
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7385-1.patch
>
>
> Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
> ie.:
> Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7385) Remove
StringUtils.stringifyException(ie) in logger functions
Posted by "Bharath Mundlapudi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bharath Mundlapudi updated HADOOP-7385:
---------------------------------------
Attachment: HADOOP-7385-1.patch
Attaching the patch.
> Remove StringUtils.stringifyException(ie) in logger functions
> -------------------------------------------------------------
>
> Key: HADOOP-7385
> URL: https://issues.apache.org/jira/browse/HADOOP-7385
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7385-1.patch
>
>
> Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
> ie.:
> Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7385) Remove
StringUtils.stringifyException(ie) in logger functions
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054177#comment-13054177 ]
Hadoop QA commented on HADOOP-7385:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482614/HADOOP-7385-1.patch
against trunk revision 1137724.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/668//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/668//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/668//console
This message is automatically generated.
> Remove StringUtils.stringifyException(ie) in logger functions
> -------------------------------------------------------------
>
> Key: HADOOP-7385
> URL: https://issues.apache.org/jira/browse/HADOOP-7385
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7385-1.patch
>
>
> Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
> ie.:
> Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira