You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/01 15:14:01 UTC

[jira] [Commented] (FLINK-6773) Use compression (e.g. snappy) for full check/savepoints

    [ https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071289#comment-16071289 ] 

ASF GitHub Bot commented on FLINK-6773:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4130#discussion_r125163526
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateSnapshotCompressionTest.java ---
    @@ -0,0 +1,180 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.state;
    +
    +import org.apache.flink.api.common.ExecutionConfig;
    +import org.apache.flink.api.common.state.ValueStateDescriptor;
    +import org.apache.flink.api.common.typeutils.base.StringSerializer;
    +import org.apache.flink.runtime.checkpoint.CheckpointOptions;
    +import org.apache.flink.runtime.query.TaskKvStateRegistry;
    +import org.apache.flink.runtime.state.heap.HeapKeyedStateBackend;
    +import org.apache.flink.runtime.state.heap.HeapReducingStateTest;
    +import org.apache.flink.runtime.state.internal.InternalValueState;
    +import org.apache.flink.runtime.state.memory.MemCheckpointStreamFactory;
    +
    +import org.apache.commons.io.IOUtils;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import java.util.Collections;
    +import java.util.concurrent.RunnableFuture;
    +
    +import static org.mockito.Mockito.mock;
    +
    +public class StateSnapshotCompressionTest {
    --- End diff --
    
    Good to let the `StateSnapshotCompressionTest` extend the `TestLogger`.


> Use compression (e.g. snappy) for full check/savepoints
> -------------------------------------------------------
>
>                 Key: FLINK-6773
>                 URL: https://issues.apache.org/jira/browse/FLINK-6773
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>
> We could use compression (e.g. snappy stream compression) to decrease the size of our full checkpoints and savepoints. From some initial experiments, I think there is great potential to achieve compression rates around 30-50%. Given those numbers, I think this is very low hanging fruit to implement.
> One point to consider in the implementation is that compression blocks should respect key-groups, i.e. typically it should make sense to compress per key-group.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)