You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/01/31 21:08:18 UTC
Re: Review Request 42781: Added the --cgroups_net_cls_major_handles
flag to the slave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/
-----------------------------------------------------------
(Updated Jan. 31, 2016, 8:08 p.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Added the --cgroups_net_cls_major_handles flag to the slave.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description (updated)
-------
The flag takes a uint16_t value that allows operators to specify a major handle
to be used with net_cls cgroup. The default value of this flag is
CGROUPS_NETCLS_MAJOR_HANDLE = 0x0011.
Diffs (updated)
-----
src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0
src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b
Diff: https://reviews.apache.org/r/42781/diff/
Testing (updated)
-------
Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
Thanks,
Avinash sridharan
Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle
flag to the slave.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 10:26 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added the --cgroups_net_cls_primary_handle flag to the slave.
Diffs (updated)
-----
src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7
Diff: https://reviews.apache.org/r/42781/diff/
Testing
-------
Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
Thanks,
Avinash sridharan
Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle
flag to the slave.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/#review118091
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 5, 2016, 3:32 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42781/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 3:32 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the --cgroups_net_cls_primary_handle flag to the slave.
>
>
> Diffs
> -----
>
> src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
> src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7
>
> Diff: https://reviews.apache.org/r/42781/diff/
>
>
> Testing
> -------
>
> Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle
flag to the slave.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 3:32 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added the --cgroups_net_cls_primary_handle flag to the slave.
Diffs (updated)
-----
src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7
Diff: https://reviews.apache.org/r/42781/diff/
Testing
-------
Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
Thanks,
Avinash sridharan
Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle
flag to the slave.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/
-----------------------------------------------------------
(Updated Feb. 4, 2016, 1:48 a.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added the --cgroups_net_cls_primary_handle flag to the slave.
Diffs (updated)
-----
src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7
Diff: https://reviews.apache.org/r/42781/diff/
Testing
-------
Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
Thanks,
Avinash sridharan
Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle
flag to the slave.
Posted by Avinash sridharan <av...@mesosphere.io>.
> On Feb. 3, 2016, 8:12 p.m., Jie Yu wrote:
> > src/slave/constants.cpp, line 55
> > <https://reviews.apache.org/r/42781/diff/6/?file=1230793#file1230793line55>
> >
> > I am thinking about whether we should introduce a default here or not.
> >
> > I think I also want the option that Mesos will just do the cgroups creation without assigning handles.
> >
> > That being said, can we make the flag optional and do not assign handles in net_cls cgroup if that flag is not set?
Made the flag optional.
- Avinash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/#review117668
-----------------------------------------------------------
On Feb. 3, 2016, 7:47 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42781/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 7:47 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the --cgroups_net_cls_primary_handle flag to the slave.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0
> src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2
> src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
> src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7
>
> Diff: https://reviews.apache.org/r/42781/diff/
>
>
> Testing
> -------
>
> Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle
flag to the slave.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/#review117668
-----------------------------------------------------------
src/slave/constants.cpp (line 55)
<https://reviews.apache.org/r/42781/#comment178940>
I am thinking about whether we should introduce a default here or not.
I think I also want the option that Mesos will just do the cgroups creation without assigning handles.
That being said, can we make the flag optional and do not assign handles in net_cls cgroup if that flag is not set?
- Jie Yu
On Feb. 3, 2016, 7:47 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42781/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 7:47 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the --cgroups_net_cls_primary_handle flag to the slave.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0
> src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2
> src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
> src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7
>
> Diff: https://reviews.apache.org/r/42781/diff/
>
>
> Testing
> -------
>
> Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle
flag to the slave.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 7:47 a.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added the --cgroups_net_cls_primary_handle flag to the slave.
Diffs (updated)
-----
src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0
src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2
src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7
Diff: https://reviews.apache.org/r/42781/diff/
Testing
-------
Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
Thanks,
Avinash sridharan
Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle
flag to the slave.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 12:51 a.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added the --cgroups_net_cls_primary_handle flag to the slave.
Diffs (updated)
-----
src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0
src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2
src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7
Diff: https://reviews.apache.org/r/42781/diff/
Testing
-------
Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
Thanks,
Avinash sridharan
Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle
flag to the slave.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 11:11 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added the --cgroups_net_cls_primary_handle flag to the slave.
Diffs (updated)
-----
src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0
src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2
src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b
Diff: https://reviews.apache.org/r/42781/diff/
Testing
-------
Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
Thanks,
Avinash sridharan
Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle
flag to the slave.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 10:39 p.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Added the --cgroups_net_cls_primary_handle flag to the slave.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description (updated)
-------
Added the --cgroups_net_cls_primary_handle flag to the slave.
Diffs (updated)
-----
src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0
src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2
src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b
Diff: https://reviews.apache.org/r/42781/diff/
Testing
-------
Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
Thanks,
Avinash sridharan
Re: Review Request 42781: Added the --cgroups_net_cls_major_handles
flag to the slave.
Posted by Avinash sridharan <av...@mesosphere.io>.
> On Jan. 31, 2016, 8:15 p.m., Neil Conway wrote:
> > Should update configuration.md.
Thanks for pointing this out Neil. Will create a JIRA on ASF and track it as part of the net_cls EPIC (MESOS-4343).
- Avinash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/#review117152
-----------------------------------------------------------
On Jan. 31, 2016, 8:10 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42781/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2016, 8:10 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The flag takes a uint16_t value that allows operators to specify a major handle
> to be used with net_cls cgroup. The default value of this flag is
> CGROUPS_NETCLS_MAJOR_HANDLE = 0x0011.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0
> src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
> src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
> src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b
>
> Diff: https://reviews.apache.org/r/42781/diff/
>
>
> Testing
> -------
>
> Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42781: Added the --cgroups_net_cls_major_handles
flag to the slave.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/#review117152
-----------------------------------------------------------
Should update configuration.md.
- Neil Conway
On Jan. 31, 2016, 8:10 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42781/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2016, 8:10 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The flag takes a uint16_t value that allows operators to specify a major handle
> to be used with net_cls cgroup. The default value of this flag is
> CGROUPS_NETCLS_MAJOR_HANDLE = 0x0011.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0
> src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
> src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
> src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b
>
> Diff: https://reviews.apache.org/r/42781/diff/
>
>
> Testing
> -------
>
> Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42781: Added the --cgroups_net_cls_major_handles
flag to the slave.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/
-----------------------------------------------------------
(Updated Jan. 31, 2016, 8:10 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
The flag takes a uint16_t value that allows operators to specify a major handle
to be used with net_cls cgroup. The default value of this flag is
CGROUPS_NETCLS_MAJOR_HANDLE = 0x0011.
Diffs
-----
src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0
src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6
src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b
Diff: https://reviews.apache.org/r/42781/diff/
Testing
-------
Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag.
Thanks,
Avinash sridharan