You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "SolidWallOfCode (via GitHub)" <gi...@apache.org> on 2023/11/14 16:05:34 UTC
[I] CI clang-format fails for differences in CMakeLists.txt files but "clang-format" target does not fix that. [trafficserver]
SolidWallOfCode opened a new issue, #10775:
URL: https://github.com/apache/trafficserver/issues/10775
See [here](https://ci.trafficserver.apache.org/job/Github_Builds/job/clang-format/3772/console). While this can be discovered by diving in to the output, it can be surprising that failing "clang-format" on CI isn't fixed by running "clang-format" locally. Nor is there any indication during commit there is a format issue (unlike code format changes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] CI clang-format fails for differences in CMakeLists.txt files but "clang-format" target does not fix that. [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt closed issue #10775: CI clang-format fails for differences in CMakeLists.txt files but "clang-format" target does not fix that.
URL: https://github.com/apache/trafficserver/issues/10775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] CI clang-format fails for differences in CMakeLists.txt files but "clang-format" target does not fix that. [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on issue #10775:
URL: https://github.com/apache/trafficserver/issues/10775#issuecomment-1810712471
There is a `cmake-format` target for fixing formatting on cmake files. @bneradt suggested we rename the clang-format CI job to just format so its not assumed that it was clang-format that failed the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] CI clang-format fails for differences in CMakeLists.txt files but "clang-format" target does not fix that. [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on issue #10775:
URL: https://github.com/apache/trafficserver/issues/10775#issuecomment-1810707971
#10776 fixes the issue with not catching this during the pre-commit hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] CI clang-format fails for differences in CMakeLists.txt files but "clang-format" target does not fix that. [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on issue #10775:
URL: https://github.com/apache/trafficserver/issues/10775#issuecomment-1819959131
I think this can be closed now:
* The CI job is now called “format” and running that target should address all format issues.
* And Chris fixed the pre-commit update logic to always update.
@SolidWallOfCode : are you OK closing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org