You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Joseph Wilwayco (JIRA)" <de...@myfaces.apache.org> on 2007/10/05 00:02:50 UTC

[jira] Created: (TOMAHAWK-1126) Using facet name="caption" in an Extended Datatable generates caption tags twice.

Using facet name="caption" in an Extended Datatable generates caption tags twice.
---------------------------------------------------------------------------------

                 Key: TOMAHAWK-1126
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1126
             Project: MyFaces Tomahawk
          Issue Type: Bug
    Affects Versions: 1.1.6
            Reporter: Joseph Wilwayco


html:

<t:dataTable id="currentImportsTable" headerClass="tableHeader"  columnClasses="listRowLeft, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowRight"  rowClasses="listRow" value="#{advertiserHome.myJobs}" var="job" styleClass="listBox" cellpadding="0" cellspacing="0">
<f:facet name="caption">
	<span jsfc="h:outputText">Current Imports</span>
</f:facet>
<h:column>
	<f:facet name="header">
		<span jsfc="h:outputText">File</span>
	</f:facet>
	<span jsfc="h:outputText">#{job.fileName}</span>
</h:column>
...
</t:dataTable>

Example generated html:

<table id="currentImportsTable" cellpadding="0" cellspacing="0" class="listBox">
  <caption>Current Imports</caption>
    <thead>
      <tr><th class="tableHeader" scope="col">File</th>
      <th class="tableHeader" scope="col">Creator</th>
      <th class="tableHeader" scope="col">Time Started</th>
      <th class="tableHeader" scope="col">Step</th>
      <th class="tableHeader" scope="col">Percent</th></tr>
    </thead>
  <caption>Current Imports</caption>
  <tbody id="currentImportsTable:tbody_element"></tbody>
</table> 

Note: IE displays the dual captions.  Firefox, Opera and Safari do not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-1126) Using facet name="caption" in an Extended Datatable generates caption tags twice.

Posted by "Torsten Liermann (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713664#action_12713664 ] 

Torsten Liermann commented on TOMAHAWK-1126:
--------------------------------------------

Yes, a caption facet is enough. 

> Using facet name="caption" in an Extended Datatable generates caption tags twice.
> ---------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1126
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1126
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6
>            Reporter: Joseph Wilwayco
>
> html:
> <t:dataTable id="currentImportsTable" headerClass="tableHeader"  columnClasses="listRowLeft, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowRight"  rowClasses="listRow" value="#{advertiserHome.myJobs}" var="job" styleClass="listBox" cellpadding="0" cellspacing="0">
> <f:facet name="caption">
> 	<span jsfc="h:outputText">Current Imports</span>
> </f:facet>
> <h:column>
> 	<f:facet name="header">
> 		<span jsfc="h:outputText">File</span>
> 	</f:facet>
> 	<span jsfc="h:outputText">#{job.fileName}</span>
> </h:column>
> ...
> </t:dataTable>
> Example generated html:
> <table id="currentImportsTable" cellpadding="0" cellspacing="0" class="listBox">
>   <caption>Current Imports</caption>
>     <thead>
>       <tr><th class="tableHeader" scope="col">File</th>
>       <th class="tableHeader" scope="col">Creator</th>
>       <th class="tableHeader" scope="col">Time Started</th>
>       <th class="tableHeader" scope="col">Step</th>
>       <th class="tableHeader" scope="col">Percent</th></tr>
>     </thead>
>   <caption>Current Imports</caption>
>   <tbody id="currentImportsTable:tbody_element"></tbody>
> </table> 
> Note: IE displays the dual captions.  Firefox, Opera and Safari do not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-1126) Using facet name="caption" in an Extended Datatable generates caption tags twice.

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713833#action_12713833 ] 

Leonardo Uribe commented on TOMAHAWK-1126:
------------------------------------------

The error comes from MYFACES-1613. Caption code was added twice, without notice it. The solution is remove the line causing it and redirect in proper way HtmlTableRendererBase.renderCaptionFacet

> Using facet name="caption" in an Extended Datatable generates caption tags twice.
> ---------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1126
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1126
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.7, 1.1.8
>            Reporter: Joseph Wilwayco
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.9-SNAPSHOT
>
>
> html:
> <t:dataTable id="currentImportsTable" headerClass="tableHeader"  columnClasses="listRowLeft, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowRight"  rowClasses="listRow" value="#{advertiserHome.myJobs}" var="job" styleClass="listBox" cellpadding="0" cellspacing="0">
> <f:facet name="caption">
> 	<span jsfc="h:outputText">Current Imports</span>
> </f:facet>
> <h:column>
> 	<f:facet name="header">
> 		<span jsfc="h:outputText">File</span>
> 	</f:facet>
> 	<span jsfc="h:outputText">#{job.fileName}</span>
> </h:column>
> ...
> </t:dataTable>
> Example generated html:
> <table id="currentImportsTable" cellpadding="0" cellspacing="0" class="listBox">
>   <caption>Current Imports</caption>
>     <thead>
>       <tr><th class="tableHeader" scope="col">File</th>
>       <th class="tableHeader" scope="col">Creator</th>
>       <th class="tableHeader" scope="col">Time Started</th>
>       <th class="tableHeader" scope="col">Step</th>
>       <th class="tableHeader" scope="col">Percent</th></tr>
>     </thead>
>   <caption>Current Imports</caption>
>   <tbody id="currentImportsTable:tbody_element"></tbody>
> </table> 
> Note: IE displays the dual captions.  Firefox, Opera and Safari do not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-1126) Using facet name="caption" in an Extended Datatable generates caption tags twice.

Posted by "Torsten Liermann (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713490#action_12713490 ] 

Torsten Liermann commented on TOMAHAWK-1126:
--------------------------------------------

Hi,

why closed? I have exactly the same problem with myfaces 1.2.6. and tomahawk12-1.1.8. IE displays the dual captions. Firefox do not.

Thanks
Torsten


> Using facet name="caption" in an Extended Datatable generates caption tags twice.
> ---------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1126
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1126
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6
>            Reporter: Joseph Wilwayco
>
> html:
> <t:dataTable id="currentImportsTable" headerClass="tableHeader"  columnClasses="listRowLeft, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowRight"  rowClasses="listRow" value="#{advertiserHome.myJobs}" var="job" styleClass="listBox" cellpadding="0" cellspacing="0">
> <f:facet name="caption">
> 	<span jsfc="h:outputText">Current Imports</span>
> </f:facet>
> <h:column>
> 	<f:facet name="header">
> 		<span jsfc="h:outputText">File</span>
> 	</f:facet>
> 	<span jsfc="h:outputText">#{job.fileName}</span>
> </h:column>
> ...
> </t:dataTable>
> Example generated html:
> <table id="currentImportsTable" cellpadding="0" cellspacing="0" class="listBox">
>   <caption>Current Imports</caption>
>     <thead>
>       <tr><th class="tableHeader" scope="col">File</th>
>       <th class="tableHeader" scope="col">Creator</th>
>       <th class="tableHeader" scope="col">Time Started</th>
>       <th class="tableHeader" scope="col">Step</th>
>       <th class="tableHeader" scope="col">Percent</th></tr>
>     </thead>
>   <caption>Current Imports</caption>
>   <tbody id="currentImportsTable:tbody_element"></tbody>
> </table> 
> Note: IE displays the dual captions.  Firefox, Opera and Safari do not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-1126) Using facet name="caption" in an Extended Datatable generates caption tags twice.

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713655#action_12713655 ] 

Leonardo Uribe commented on TOMAHAWK-1126:
------------------------------------------

For reproduce the error it is just put a caption facet? the report on myfaces jira says something about a ear. Anyway I'll take a look at it.

> Using facet name="caption" in an Extended Datatable generates caption tags twice.
> ---------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1126
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1126
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6
>            Reporter: Joseph Wilwayco
>
> html:
> <t:dataTable id="currentImportsTable" headerClass="tableHeader"  columnClasses="listRowLeft, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowRight"  rowClasses="listRow" value="#{advertiserHome.myJobs}" var="job" styleClass="listBox" cellpadding="0" cellspacing="0">
> <f:facet name="caption">
> 	<span jsfc="h:outputText">Current Imports</span>
> </f:facet>
> <h:column>
> 	<f:facet name="header">
> 		<span jsfc="h:outputText">File</span>
> 	</f:facet>
> 	<span jsfc="h:outputText">#{job.fileName}</span>
> </h:column>
> ...
> </t:dataTable>
> Example generated html:
> <table id="currentImportsTable" cellpadding="0" cellspacing="0" class="listBox">
>   <caption>Current Imports</caption>
>     <thead>
>       <tr><th class="tableHeader" scope="col">File</th>
>       <th class="tableHeader" scope="col">Creator</th>
>       <th class="tableHeader" scope="col">Time Started</th>
>       <th class="tableHeader" scope="col">Step</th>
>       <th class="tableHeader" scope="col">Percent</th></tr>
>     </thead>
>   <caption>Current Imports</caption>
>   <tbody id="currentImportsTable:tbody_element"></tbody>
> </table> 
> Note: IE displays the dual captions.  Firefox, Opera and Safari do not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (TOMAHAWK-1126) Using facet name="caption" in an Extended Datatable generates caption tags twice.

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe reopened TOMAHAWK-1126:
--------------------------------------

      Assignee: Leonardo Uribe

Reopened because conditions where this issue occur appear (not on tomahawk but on tomahawk core12)

> Using facet name="caption" in an Extended Datatable generates caption tags twice.
> ---------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1126
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1126
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6
>            Reporter: Joseph Wilwayco
>            Assignee: Leonardo Uribe
>
> html:
> <t:dataTable id="currentImportsTable" headerClass="tableHeader"  columnClasses="listRowLeft, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowRight"  rowClasses="listRow" value="#{advertiserHome.myJobs}" var="job" styleClass="listBox" cellpadding="0" cellspacing="0">
> <f:facet name="caption">
> 	<span jsfc="h:outputText">Current Imports</span>
> </f:facet>
> <h:column>
> 	<f:facet name="header">
> 		<span jsfc="h:outputText">File</span>
> 	</f:facet>
> 	<span jsfc="h:outputText">#{job.fileName}</span>
> </h:column>
> ...
> </t:dataTable>
> Example generated html:
> <table id="currentImportsTable" cellpadding="0" cellspacing="0" class="listBox">
>   <caption>Current Imports</caption>
>     <thead>
>       <tr><th class="tableHeader" scope="col">File</th>
>       <th class="tableHeader" scope="col">Creator</th>
>       <th class="tableHeader" scope="col">Time Started</th>
>       <th class="tableHeader" scope="col">Step</th>
>       <th class="tableHeader" scope="col">Percent</th></tr>
>     </thead>
>   <caption>Current Imports</caption>
>   <tbody id="currentImportsTable:tbody_element"></tbody>
> </table> 
> Note: IE displays the dual captions.  Firefox, Opera and Safari do not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TOMAHAWK-1126) Using facet name="caption" in an Extended Datatable generates caption tags twice.

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved TOMAHAWK-1126.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.9-SNAPSHOT

> Using facet name="caption" in an Extended Datatable generates caption tags twice.
> ---------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1126
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1126
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.7, 1.1.8
>            Reporter: Joseph Wilwayco
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.9-SNAPSHOT
>
>
> html:
> <t:dataTable id="currentImportsTable" headerClass="tableHeader"  columnClasses="listRowLeft, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowMid, listRowRight"  rowClasses="listRow" value="#{advertiserHome.myJobs}" var="job" styleClass="listBox" cellpadding="0" cellspacing="0">
> <f:facet name="caption">
> 	<span jsfc="h:outputText">Current Imports</span>
> </f:facet>
> <h:column>
> 	<f:facet name="header">
> 		<span jsfc="h:outputText">File</span>
> 	</f:facet>
> 	<span jsfc="h:outputText">#{job.fileName}</span>
> </h:column>
> ...
> </t:dataTable>
> Example generated html:
> <table id="currentImportsTable" cellpadding="0" cellspacing="0" class="listBox">
>   <caption>Current Imports</caption>
>     <thead>
>       <tr><th class="tableHeader" scope="col">File</th>
>       <th class="tableHeader" scope="col">Creator</th>
>       <th class="tableHeader" scope="col">Time Started</th>
>       <th class="tableHeader" scope="col">Step</th>
>       <th class="tableHeader" scope="col">Percent</th></tr>
>     </thead>
>   <caption>Current Imports</caption>
>   <tbody id="currentImportsTable:tbody_element"></tbody>
> </table> 
> Note: IE displays the dual captions.  Firefox, Opera and Safari do not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.