[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5008: Decouple service (compute) offering and disk offering

[GitBox <gi...@apache.org>]

harikrishna-patnala commented on a change in pull request #5008:
URL: https://github.com/apache/cloudstack/pull/5008#discussion_r671018242



##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -2403,7 +2427,7 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
         if (diskOffering == null) {
             throw new CloudRuntimeException("volume '" + vol.getUuid() + "', has no diskoffering. Migration target cannot be checked.");
         }
-        if (!doesTargetStorageSupportDiskOffering(destPool, diskOffering)) {
+        if (VolumeTagsStoragePoolStrictness.valueIn(destPool.getDataCenterId()) && !doesTargetStorageSupportDiskOffering(destPool, diskOffering)) {

Review comment:
       I'm referring to the above change in the PR https://github.com/apache/cloudstack/pull/4257




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org