You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/06/13 05:28:29 UTC
[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role configured
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7167
Change subject: IMPALA-5495: Improve error message if no impalad role configured
......................................................................
IMPALA-5495: Improve error message if no impalad role configured
"Impala server needs to have a role (EXECUTOR, COORDINATOR)"
replaced with:
"Impala does not have a valid role configured. Either --is_coordinator or
--is_executor must be set to true."
Change-Id: Ib8ae09eeaefeda3fab62e66dbcb4f9134082c039
---
M be/src/service/impala-server.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/7167/1
--
To view, visit http://gerrit.cloudera.org:8080/7167
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8ae09eeaefeda3fab62e66dbcb4f9134082c039
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello anujphadke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7167
to look at the new patch set (#2).
Change subject: IMPALA-5495: Improve error message if no impalad role is configured
......................................................................
IMPALA-5495: Improve error message if no impalad role is configured
"Impala server needs to have a role (EXECUTOR, COORDINATOR)"
replaced with:
"Impala does not have a valid role configured. Either --is_coordinator or
--is_executor must be set to true."
Change-Id: Ib8ae09eeaefeda3fab62e66dbcb4f9134082c039
---
M be/src/service/impala-server.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/7167/2
--
To view, visit http://gerrit.cloudera.org:8080/7167
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib8ae09eeaefeda3fab62e66dbcb4f9134082c039
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5495: Improve error message if no impalad role is configured
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7167
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8ae09eeaefeda3fab62e66dbcb4f9134082c039
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5495: Improve error message if no impalad role is configured
......................................................................
Patch Set 2: Code-Review+2
Thanks for fixing this :)
--
To view, visit http://gerrit.cloudera.org:8080/7167
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8ae09eeaefeda3fab62e66dbcb4f9134082c039
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5495: Improve error message if no impalad role is configured
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7167/1//COMMIT_MSG
Commit Message:
Line 7: IMPALA-5495: Improve error message if no impalad role configured
> role is configured.
Done
--
To view, visit http://gerrit.cloudera.org:8080/7167
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8ae09eeaefeda3fab62e66dbcb4f9134082c039
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5495: Improve error message if no impalad role is configured
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/727/
--
To view, visit http://gerrit.cloudera.org:8080/7167
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8ae09eeaefeda3fab62e66dbcb4f9134082c039
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5495: Improve error message if no impalad role is configured
......................................................................
IMPALA-5495: Improve error message if no impalad role is configured
"Impala server needs to have a role (EXECUTOR, COORDINATOR)"
replaced with:
"Impala does not have a valid role configured. Either --is_coordinator or
--is_executor must be set to true."
Change-Id: Ib8ae09eeaefeda3fab62e66dbcb4f9134082c039
Reviewed-on: http://gerrit.cloudera.org:8080/7167
Reviewed-by: Dimitris Tsirogiannis <dt...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/service/impala-server.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Dimitris Tsirogiannis: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7167
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8ae09eeaefeda3fab62e66dbcb4f9134082c039
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role configured
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has posted comments on this change.
Change subject: IMPALA-5495: Improve error message if no impalad role configured
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7167/1//COMMIT_MSG
Commit Message:
Line 7: IMPALA-5495: Improve error message if no impalad role configured
role is configured.
--
To view, visit http://gerrit.cloudera.org:8080/7167
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8ae09eeaefeda3fab62e66dbcb4f9134082c039
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: Yes