You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/29 08:58:43 UTC
[GitHub] [spark] cloud-fan opened a new pull request #35056: [SPARK-37777][SQL] Update the SQL syntax of SHOW FUNCTIONS
cloud-fan opened a new pull request #35056:
URL: https://github.com/apache/spark/pull/35056
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
The SQL syntax of `SHOW FUNCTIONS` is very weird today. If you want to specify the database to list functions, you need to write `SHOW FUNCTIONS LIKE db.f1`. This is inconsistent with `SHOW TABLES` and `SHOW VIEWS`.
This PR proposes to follow `SHOW TABLES` and `SHOW VIEWS`, and support `SHOW FUNCTIONS FROM/IN db LIKE pattern`. To keep backward compatibility, the legacy syntax is still supported, but it can't be used together with the new `FROM/IN db` clause.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Be consistent with `SHOW TABLES` and `SHOW VIEWS`
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yea, as it extends the `SHOW FUNCTIONS` SQL syntax.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
updated tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #35056: [SPARK-37777][SQL] Update the SQL syntax of SHOW FUNCTIONS
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #35056:
URL: https://github.com/apache/spark/pull/35056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #35056: [SPARK-37777][SQL] Update the SQL syntax of SHOW FUNCTIONS
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35056:
URL: https://github.com/apache/spark/pull/35056#issuecomment-1002468743
cc @MaxGekk @imback82 @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #35056: [SPARK-37777][SQL] Update the SQL syntax of SHOW FUNCTIONS
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #35056:
URL: https://github.com/apache/spark/pull/35056#discussion_r776524589
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -2132,29 +2132,34 @@ class DDLParserSuite extends AnalysisTest {
}
test("SHOW FUNCTIONS") {
+ val nsPlan = UnresolvedNamespace(Nil)
comparePlans(
parsePlan("SHOW FUNCTIONS"),
- ShowFunctions(None, true, true, None))
+ ShowFunctions(nsPlan, true, true, None))
comparePlans(
parsePlan("SHOW USER FUNCTIONS"),
- ShowFunctions(None, true, false, None))
+ ShowFunctions(nsPlan, true, false, None))
comparePlans(
parsePlan("SHOW user FUNCTIONS"),
- ShowFunctions(None, true, false, None))
+ ShowFunctions(nsPlan, true, false, None))
comparePlans(
parsePlan("SHOW SYSTEM FUNCTIONS"),
- ShowFunctions(None, false, true, None))
+ ShowFunctions(nsPlan, false, true, None))
comparePlans(
parsePlan("SHOW ALL FUNCTIONS"),
- ShowFunctions(None, true, true, None))
+ ShowFunctions(nsPlan, true, true, None))
comparePlans(
parsePlan("SHOW FUNCTIONS LIKE 'funct*'"),
- ShowFunctions(None, true, true, Some("funct*")))
+ ShowFunctions(nsPlan, true, true, Some("funct*")))
+ comparePlans(
+ parsePlan("SHOW FUNCTIONS IN db LIKE 'funct*'"),
+ ShowFunctions(UnresolvedNamespace(Seq("db")), true, true, Some("funct*")))
comparePlans(
parsePlan("SHOW FUNCTIONS LIKE a.b.c"),
- ShowFunctions(Some(UnresolvedFunc(Seq("a", "b", "c"))), true, true, None))
+ ShowFunctions(UnresolvedNamespace(Seq("a", "b")), true, true, Some("c")))
val sql = "SHOW other FUNCTIONS"
intercept(sql, s"$sql not supported")
+ intercept("SHOW FUNCTIONS IN db f1", "Invalid pattern")
Review comment:
nit: add full error message?
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -2132,29 +2132,34 @@ class DDLParserSuite extends AnalysisTest {
}
test("SHOW FUNCTIONS") {
+ val nsPlan = UnresolvedNamespace(Nil)
comparePlans(
parsePlan("SHOW FUNCTIONS"),
- ShowFunctions(None, true, true, None))
+ ShowFunctions(nsPlan, true, true, None))
comparePlans(
parsePlan("SHOW USER FUNCTIONS"),
- ShowFunctions(None, true, false, None))
+ ShowFunctions(nsPlan, true, false, None))
comparePlans(
parsePlan("SHOW user FUNCTIONS"),
- ShowFunctions(None, true, false, None))
+ ShowFunctions(nsPlan, true, false, None))
comparePlans(
parsePlan("SHOW SYSTEM FUNCTIONS"),
- ShowFunctions(None, false, true, None))
+ ShowFunctions(nsPlan, false, true, None))
comparePlans(
parsePlan("SHOW ALL FUNCTIONS"),
- ShowFunctions(None, true, true, None))
+ ShowFunctions(nsPlan, true, true, None))
comparePlans(
parsePlan("SHOW FUNCTIONS LIKE 'funct*'"),
- ShowFunctions(None, true, true, Some("funct*")))
+ ShowFunctions(nsPlan, true, true, Some("funct*")))
+ comparePlans(
+ parsePlan("SHOW FUNCTIONS IN db LIKE 'funct*'"),
+ ShowFunctions(UnresolvedNamespace(Seq("db")), true, true, Some("funct*")))
comparePlans(
parsePlan("SHOW FUNCTIONS LIKE a.b.c"),
Review comment:
Can you add a test `SHOW FUNCTIONS LIKE a` so that namespace becomes `nsPlan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #35056: [SPARK-37777][SQL] Update the SQL syntax of SHOW FUNCTIONS
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35056:
URL: https://github.com/apache/spark/pull/35056#issuecomment-1002854853
> Do we need to add new syntax to migration guide?
IIUC migration guide is for breaking changes, not new features. Since this PR doesn't break anything, we don't need to update migration guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #35056: [SPARK-37777][SQL] Update the SQL syntax of SHOW FUNCTIONS
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #35056:
URL: https://github.com/apache/spark/pull/35056#discussion_r776524589
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -2132,29 +2132,34 @@ class DDLParserSuite extends AnalysisTest {
}
test("SHOW FUNCTIONS") {
+ val nsPlan = UnresolvedNamespace(Nil)
comparePlans(
parsePlan("SHOW FUNCTIONS"),
- ShowFunctions(None, true, true, None))
+ ShowFunctions(nsPlan, true, true, None))
comparePlans(
parsePlan("SHOW USER FUNCTIONS"),
- ShowFunctions(None, true, false, None))
+ ShowFunctions(nsPlan, true, false, None))
comparePlans(
parsePlan("SHOW user FUNCTIONS"),
- ShowFunctions(None, true, false, None))
+ ShowFunctions(nsPlan, true, false, None))
comparePlans(
parsePlan("SHOW SYSTEM FUNCTIONS"),
- ShowFunctions(None, false, true, None))
+ ShowFunctions(nsPlan, false, true, None))
comparePlans(
parsePlan("SHOW ALL FUNCTIONS"),
- ShowFunctions(None, true, true, None))
+ ShowFunctions(nsPlan, true, true, None))
comparePlans(
parsePlan("SHOW FUNCTIONS LIKE 'funct*'"),
- ShowFunctions(None, true, true, Some("funct*")))
+ ShowFunctions(nsPlan, true, true, Some("funct*")))
+ comparePlans(
+ parsePlan("SHOW FUNCTIONS IN db LIKE 'funct*'"),
+ ShowFunctions(UnresolvedNamespace(Seq("db")), true, true, Some("funct*")))
comparePlans(
parsePlan("SHOW FUNCTIONS LIKE a.b.c"),
- ShowFunctions(Some(UnresolvedFunc(Seq("a", "b", "c"))), true, true, None))
+ ShowFunctions(UnresolvedNamespace(Seq("a", "b")), true, true, Some("c")))
val sql = "SHOW other FUNCTIONS"
intercept(sql, s"$sql not supported")
+ intercept("SHOW FUNCTIONS IN db f1", "Invalid pattern")
Review comment:
nit: add full error message (helpful when searching for a corresponding test case)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35056: [SPARK-37777][SQL] Update the SQL syntax of SHOW FUNCTIONS
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35056:
URL: https://github.com/apache/spark/pull/35056#discussion_r776390428
##########
File path: docs/sql-ref-syntax-aux-show-functions.md
##########
@@ -30,7 +30,7 @@ clause is optional and supported only for compatibility with other systems.
### Syntax
```sql
-SHOW [ function_kind ] FUNCTIONS [ [ LIKE ] { function_name | regex_pattern } ]
+SHOW [ function_kind ] FUNCTIONS [ { FROM | IN } database_name ] [ LIKE regex_pattern ]
Review comment:
I removed the document for the legacy syntax as a soft deprecation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #35056: [SPARK-37777][SQL] Update the SQL syntax of SHOW FUNCTIONS
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35056:
URL: https://github.com/apache/spark/pull/35056#issuecomment-1003025387
thanks for the review, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org