You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Aaron T. Myers (Created) (JIRA)" <ji...@apache.org> on 2012/02/23 17:12:48 UTC
[jira] [Created] (HDFS-2998) OfflineImageViewer and ImageVisitor
should be annotated public
OfflineImageViewer and ImageVisitor should be annotated public
--------------------------------------------------------------
Key: HDFS-2998
URL: https://issues.apache.org/jira/browse/HDFS-2998
Project: Hadoop HDFS
Issue Type: New Feature
Affects Versions: 0.23.1
Reporter: Aaron T. Myers
The OfflineImageViewer is currently annotated as InterfaceAudience.Private. It's intended for subclassing, so it should be annotated as the public API that it is.
The ImageVisitor class should similarly be annotated public (evolving is fine). Note that it should also be changed to be public; it's currently package-private, which means that users have to cheat with their subclass package name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2998) OfflineImageViewer and ImageVisitor
should be annotated public
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas resolved HDFS-2998.
-----------------------------------
Resolution: Not A Problem
I am going to mark this as not a problem. If you disagree, with valid reasons, please reopen the jira.
> OfflineImageViewer and ImageVisitor should be annotated public
> --------------------------------------------------------------
>
> Key: HDFS-2998
> URL: https://issues.apache.org/jira/browse/HDFS-2998
> Project: Hadoop HDFS
> Issue Type: New Feature
> Affects Versions: 0.23.1
> Reporter: Aaron T. Myers
>
> The OfflineImageViewer is currently annotated as InterfaceAudience.Private. It's intended for subclassing, so it should be annotated as the public API that it is.
> The ImageVisitor class should similarly be annotated public (evolving is fine). Note that it should also be changed to be public; it's currently package-private, which means that users have to cheat with their subclass package name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HDFS-2998) OfflineImageViewer and ImageVisitor
should be annotated public
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers reopened HDFS-2998:
----------------------------------
My apologies that this fell off my radar. I still believe that this is a useful interface for external developers, and thus that we should mark it public/unstable or public/evolving.
I agree that doing so would require marking the referenced classes similarly public/(evolving|unstable).
> OfflineImageViewer and ImageVisitor should be annotated public
> --------------------------------------------------------------
>
> Key: HDFS-2998
> URL: https://issues.apache.org/jira/browse/HDFS-2998
> Project: Hadoop HDFS
> Issue Type: New Feature
> Affects Versions: 0.23.1
> Reporter: Aaron T. Myers
>
> The OfflineImageViewer is currently annotated as InterfaceAudience.Private. It's intended for subclassing, so it should be annotated as the public API that it is.
> The ImageVisitor class should similarly be annotated public (evolving is fine). Note that it should also be changed to be public; it's currently package-private, which means that users have to cheat with their subclass package name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira