You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by ha...@apache.org on 2022/08/08 07:02:54 UTC
[hop] branch master updated: HOP-HOP-4082: Get rid of empty "Settings" tab or fill it
This is an automated email from the ASF dual-hosted git repository.
hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/master by this push:
new 904712431e HOP-HOP-4082: Get rid of empty "Settings" tab or fill it
new 5433acf648 Merge pull request #1624 from uraychang/master
904712431e is described below
commit 904712431e012ab2488790817f50583d07871254
Author: ray.chang <ur...@gmail.com>
AuthorDate: Mon Aug 8 10:47:38 2022 +0800
HOP-HOP-4082: Get rid of empty "Settings" tab or fill it
---
.../hop/ui/workflow/dialog/WorkflowDialog.java | 31 ----------------------
1 file changed, 31 deletions(-)
diff --git a/ui/src/main/java/org/apache/hop/ui/workflow/dialog/WorkflowDialog.java b/ui/src/main/java/org/apache/hop/ui/workflow/dialog/WorkflowDialog.java
index 2a0aafcc60..f2a1168a47 100644
--- a/ui/src/main/java/org/apache/hop/ui/workflow/dialog/WorkflowDialog.java
+++ b/ui/src/main/java/org/apache/hop/ui/workflow/dialog/WorkflowDialog.java
@@ -146,7 +146,6 @@ public class WorkflowDialog extends Dialog {
addWorkflowTab();
addParamTab();
- addSettingsTab();
// See if there are any other tabs to be added...
extraTabs = new ArrayList<>();
@@ -538,36 +537,6 @@ public class WorkflowDialog extends Dialog {
// ///////////////////////////////////////////////////////////
}
- private void addSettingsTab() {
- // ////////////////////////
- // START OF SETTINGS TAB///
- // /
- CTabItem wSettingsTab = new CTabItem(wTabFolder, SWT.NONE);
- wSettingsTab.setText(BaseMessages.getString(PKG, "WorkflowDialog.SettingsTab.Label"));
-
- FormLayout logLayout = new FormLayout();
- logLayout.marginWidth = props.getMargin();
- logLayout.marginHeight = props.getMargin();
-
- Composite wSettingsComp = new Composite(wTabFolder, SWT.NONE);
- props.setLook(wSettingsComp);
- wSettingsComp.setLayout(logLayout);
-
- FormData fdLogComp = new FormData();
- fdLogComp.left = new FormAttachment(0, 0);
- fdLogComp.top = new FormAttachment(0, 0);
- fdLogComp.right = new FormAttachment(100, 0);
- fdLogComp.bottom = new FormAttachment(100, 0);
- wSettingsComp.setLayoutData(fdLogComp);
-
- wSettingsComp.layout();
- wSettingsTab.setControl(wSettingsComp);
-
- // ///////////////////////////////////////////////////////////
- // / END OF LOG TAB
- // ///////////////////////////////////////////////////////////
- }
-
public void dispose() {
WindowProperty winprop = new WindowProperty(shell);
props.setScreen(winprop);