[jira] [Commented] (FLINK-7802) Exception occur when empty field collection was pushed into CSVTableSource

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201843#comment-16201843 ] 

ASF GitHub Bot commented on FLINK-7802:
---------------------------------------

GitHub user godfreyhe opened a pull request:

    https://github.com/apache/flink/pull/4815

    [FLINK-7802] [hotfix] Exception occur when empty field collection was pushed into CSVTableSource

    ## What is the purpose of the change
    
    *This pull request fix the bug: Exception occur when empty field collection was pushed into CSVTableSource*
    
    
    ## Brief change log
    
      - *Handle empty field collection in CSVTableSource when project push down*
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - *Add integration tests for SQL like: select count(1) from csv_table*
      
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not documented)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/godfreyhe/flink FLINK-7802

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4815.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4815
    
----
commit 5694fb2fad223f733be9e92512f6534e0e3d37bb
Author: godfreyhe <go...@163.com>
Date:   2017-10-12T11:12:47Z

    [FLINK-7802] [hotfix] Exception occur when empty field collection was pushed into CSVTableSource

----


> Exception occur when empty field collection was pushed into CSVTableSource
> --------------------------------------------------------------------------
>
>                 Key: FLINK-7802
>                 URL: https://issues.apache.org/jira/browse/FLINK-7802
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: godfrey he
>            Assignee: godfrey he
>
> Consider such SQL: select count(1) from csv_table. 
> When above SQL was executed, an exception will occur:
> java.lang.IllegalArgumentException: At least one field must be specified
> at org.apache.flink.api.java.io.RowCsvInputFormat.<init>(RowCsvInputFormat.java:50)
> So if no fields will be used, we should also keep some columns for CSVTableSource to get row count.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)