You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Wang1rrr (via GitHub)" <gi...@apache.org> on 2026/10/19 03:28:09 UTC

[PR] fix(build): copy legal inputs into the Maven Docker stage [rocketmq-dashboard]

Wang1rrr opened a new pull request, #6985:
URL: https://github.com/apache/rocketmq-dashboard/pull/6985

   ## Summary
   Closes #6984.
   
   Copy the existing license determination table and collected upstream license texts into `/app` before Maven packaging in the independent `build` stage. The package-phase gate resolves paths from `/app/scripts/legal.py`; the copies in `runtime-base` are unavailable in this stage.
   
   Add a stage-scoped regression so files copied into another Docker stage cannot accidentally satisfy the check.
   
   ## Validation
   - Before: the new regression fails for both missing build-stage COPY instructions.
   - After: `python -m unittest discover -s server/scripts -p legal_test.py` passes all 7 tests (Python 3.12).
   - `git diff --check` passes.
   - Full Docker image build not run; no license policy or gate behavior changed.
   
   AI assistance was used; the diff and regression results were reviewed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(build): copy legal inputs into the Maven Docker stage [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #6985: fix(build): copy legal inputs into the Maven Docker stage
URL: https://github.com/apache/rocketmq-dashboard/pull/6985


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(build): copy legal inputs into the Maven Docker stage [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #6985:
URL: https://github.com/apache/rocketmq-dashboard/pull/6985#issuecomment-6433484738

   Merged as part of #6991 - squashed into `rocketmq-studio` as `8aebce7fc`.
   
   Your change here (copy `legal-determinations.json` and `legal/licenses` into the Maven Docker stage, so a Docker-only build can run the same license check as a host build) is included.
   
   We grouped 5 of your related build and deployment fixes into a single commit so the history stays reviewable; the other PRs in the group are closed with the same note. Everything was cherry-picked onto the current baseline with you kept as the author, and your tests came along with the change.
   
   Thanks for the consistently well-tested patches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org