You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/06/27 11:47:30 UTC
[GitHub] [cloudstack] RodrigoDLopez opened a new pull request, #6507: Externalizes logrotate service frequency timer in VR
RodrigoDLopez opened a new pull request, #6507:
URL: https://github.com/apache/cloudstack/pull/6507
### Description
Currently, the frequency of execution of the logrotate service, in virtual routers, is defined to be executed every hour, and it is not possible to change this value via ACS.
This behavior has been fixed so that the operator is now able to define this interval using the global configuration `router.logrotate.frequency`, which follows the pattern adopted by the onCalendar field of the Systemd Timers tool. Such a pattern uses the format: [* *-*-* *:*:*] which means [<DAY_OF_WEEK> <YEAR>-<MONTH>-<DAY> <HOUR>:<MINUTE>:<SECOND>]. However, the ACS uses only the last block of this format, that is, [<HOUR>:<MINUTE>:<SECOND>], since the use cases presented show that times greater than 24 hours lead to problems in the VRs resulting from discharge disk space usage.
The default value for this setting was kept, being represented by: *:00:00 (hourly). The table below represents some of the possible values and their meanings:
| Valor | Significado |
|---------------|-----------------------------------|
| \*:\*:00 | Todo Minuto |
| \*:\*/15:00 | A cada 15 minutos |
| \*:00:00 | Toda hora |
| \*/2:00:00 | A cada 2 horas |
| 00:00:00 | Todo dia exatamente às 00:00:00 |
**Note**: the minimum file size is fixed at 10M, which means that the logrotate service will run, but it will not rotate the log files if it does not reach the minimum size.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
Changing the value of `router.logrotate.frequency` and checking if this value has been applied in the VR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1232639162
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1275672294
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1275672104
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1237423888
@DaanHoogland, are the smoke tests failures related to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1171963390
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1206376312
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1291255972
<b>Trillian test result (tid-5198)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41115 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6507-t5198-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 463.79 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1290398074
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1232969335
<b>Trillian Build Failed (tid-4790)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1200406133
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1206332850
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1206376577
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1277248540
<b>Trillian Build Failed (tid-5117)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1252790985
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1253511958
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1208152827
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6507 (SL-JID-2105)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1278772623
<b>Trillian Build Failed (tid-5125)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1277166228
<b>Trillian Build Failed (tid-5112)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1200416892
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1206279140
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1290167594
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1169178197
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6507)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1168387250
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1252790052
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1290224452
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1208224989
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6507)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1171982938
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1179570196
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1281124909
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1276692750
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1238061912
> @DaanHoogland, are the smoke tests failures related to this PR?
@GutoVeronezi , I wouldn´t know how, but it is possible of course. It might also be because our lab is overloaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1168206538
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1207224936
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1207226842
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1232600157
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1232686712
<b>Trillian Build Failed (tid-4785)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1252866118
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6507)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_coverage&view=list) [17.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1253510484
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1272285027
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1202439818
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1200492239
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1290279365
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1252796222
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6507 (SL-JID-2386)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1252830880
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6507?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`main@117ce1a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #6507 +/- ##
=======================================
Coverage ? 10.42%
Complexity ? 6702
=======================================
Files ? 2458
Lines ? 243257
Branches ? 38068
=======================================
Hits ? 25360
Misses ? 214723
Partials ? 3174
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1277116524
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1208146966
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1207226085
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1231843548
@DaanHoogland, @weizhouapache
is there anything else missing on this one, or we are good to go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1167423580
@blueorabgutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1168206962
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1169531936
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r940021899
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,13 +2131,36 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ if (!checkLogrotateTimerPattern(routerLogrotateFrequency)) {
+ s_logger.debug(String.format("Setting [%s] with value [%s] do not match with the used regex [%s], or any acceptable value ('hourly', 'daily', 'monthly'); " +
+ "therefore, we will use the default value [%s] to configure the logrotate service on the virtual router.",RouterLogrotateFrequency.key(),
+ routerLogrotateFrequency, LOGROTATE_REGEX, RouterLogrotateFrequency.defaultValue()));
+ routerLogrotateFrequency = RouterLogrotateFrequency.defaultValue();
+ }
+ s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s], will be used to configure the logrotate service frequency" +
+ " on the virtual router.", RouterLogrotateFrequency.key(), routerLogrotateFrequency, dc.getUuid()));
+ buf.append(String.format(" logrotatefrequency=%s", routerLogrotateFrequency));
+
if (s_logger.isDebugEnabled()) {
s_logger.debug("Boot Args for " + profile + ": " + buf.toString());
}
return true;
}
+ /**
+ * @param routerLogrotateFrequency The string to be checked if matches with any acceptable values.
+ * Checks if the value in the global configuration is an acceptable value to be informed to the Virtual Router.
+ * @return true if the passed value match with any acceptable value based on the regex ((?i)(hourly)|(daily)|(monthly))|(\*|\d{2})\:(\*|\d{2})\:(\*|\d{2})
+ */
+ protected boolean checkLogrotateTimerPattern(String routerLogrotateFrequency) {
+ if (Pattern.matches(LOGROTATE_REGEX, routerLogrotateFrequency)) {
+ return true;
+ }
+ return false;
Review Comment:
```suggestion
return Pattern.matches(LOGROTATE_REGEX, routerLogrotateFrequency);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1209104139
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1284033538
@RodrigoDLopez can you rebase this one on latest main. I see software version discrepancies in the systemvms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1280799247
<b>Trillian Build Failed (tid-5158)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1232639614
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1272245302
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1168267772
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1169110268
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r908022029
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,6 +2126,11 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ s_logger.debug(String.format("The global setting [%s], with value [%s], will be used to configure the logrotate service frequency on the virtual router.",
Review Comment:
It's not from the global setting always, so better to log zone id as well.
```suggestion
s_logger.debug(String.format("The setting [%s] with value [%s] for the zone [%s], will be used to configure the logrotate service frequency on the virtual router.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r912902904
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManager.java:
##########
@@ -114,6 +114,12 @@ public interface VirtualNetworkApplianceManager extends Manager, VirtualNetworkA
static final ConfigKey<Double> RouterHealthChecksMaxMemoryUsageThreshold = new ConfigKey<Double>(Double.class, "router.health.checks.max.memory.usage.threshold",
"Advanced", "100", "Max Memory Usage threshold as % above which check is considered a failure.",
true, ConfigKey.Scope.Zone, null);
+ ConfigKey<String> RouterLogrotateFrequency = new ConfigKey<String>(String.class, "router.logrotate.frequency", "Advanced", "*:00:00",
Review Comment:
```suggestion
ConfigKey<String> RouterLogrotateFrequency = new ConfigKey<>(String.class, "router.logrotate.frequency", "Advanced", "*:00:00",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1171963828
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r938757828
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,6 +2126,11 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s], will be used to configure the logrotate service frequency" +
+ " on the virtual router.", RouterLogrotateFrequency.key(), routerLogrotateFrequency, dc.getUuid()));
+ buf.append(String.format(" logrotatefrequency=%s", routerLogrotateFrequency));
Review Comment:
@weizhouapache do you mean an invalid `logrotatefrequency`, and add a validator method for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1207648647
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1290429313
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1168388175
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1179570225
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1207226115
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1206385737
<b>Trillian Build Failed (tid-4627)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1209103652
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1253453505
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1253512722
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1232952388
<b>Trillian Build Failed (tid-4789)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1200861149
<b>Trillian test result (tid-4585)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41507 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6507-t4585-vmware-67u3.zip
Smoke tests completed. 99 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 645.31 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1200492447
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1281124507
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r963113757
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,13 +2131,33 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ if (!checkLogrotateTimerPattern(routerLogrotateFrequency)) {
+ s_logger.debug(String.format("Setting [%s] with value [%s] do not match with the used regex [%s], or any acceptable value ('hourly', 'daily', 'monthly'); " +
+ "therefore, we will use the default value [%s] to configure the logrotate service on the virtual router.",RouterLogrotateFrequency.key(),
+ routerLogrotateFrequency, LOGROTATE_REGEX, RouterLogrotateFrequency.defaultValue()));
+ routerLogrotateFrequency = RouterLogrotateFrequency.defaultValue();
+ }
+ s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s], will be used to configure the logrotate service frequency" +
+ " on the virtual router.", RouterLogrotateFrequency.key(), routerLogrotateFrequency, dc.getUuid()));
+ buf.append(String.format(" logrotatefrequency=%s", routerLogrotateFrequency));
+
if (s_logger.isDebugEnabled()) {
s_logger.debug("Boot Args for " + profile + ": " + buf.toString());
}
return true;
}
+ /**
+ * @param routerLogrotateFrequency The string to be checked if matches with any acceptable values.
+ * Checks if the value in the global configuration is an acceptable value to be informed to the Virtual Router.
+ * @return true if the passed value match with any acceptable value based on the regex ((?i)(hourly)|(daily)|(monthly))|(\*|\d{2})\:(\*|\d{2})\:(\*|\d{2})
Review Comment:
```suggestion
* Checks if the value in the global configuration {@link VirtualNetworkApplianceManager#RouterLogrotateFrequency} is an acceptable value to be informed to the Virtual Router.
* @param routerLogrotateFrequency The string to be checked.
* @return true if the passed value matches with any acceptable value based on the regex {@value VirtualNetworkApplianceManagerImpl#LOGROTATE_REGEX}.
```
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,13 +2131,33 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ if (!checkLogrotateTimerPattern(routerLogrotateFrequency)) {
+ s_logger.debug(String.format("Setting [%s] with value [%s] do not match with the used regex [%s], or any acceptable value ('hourly', 'daily', 'monthly'); " +
Review Comment:
```suggestion
s_logger.debug(String.format("Setting [%s] with value [%s] does not match with the regex [%s], or any acceptable value ('hourly', 'daily', 'monthly'); " +
```
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,13 +2131,33 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ if (!checkLogrotateTimerPattern(routerLogrotateFrequency)) {
+ s_logger.debug(String.format("Setting [%s] with value [%s] do not match with the used regex [%s], or any acceptable value ('hourly', 'daily', 'monthly'); " +
+ "therefore, we will use the default value [%s] to configure the logrotate service on the virtual router.",RouterLogrotateFrequency.key(),
+ routerLogrotateFrequency, LOGROTATE_REGEX, RouterLogrotateFrequency.defaultValue()));
+ routerLogrotateFrequency = RouterLogrotateFrequency.defaultValue();
+ }
+ s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s], will be used to configure the logrotate service frequency" +
Review Comment:
```suggestion
s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s] will be used to configure the logrotate service frequency" +
```
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -289,6 +290,10 @@ public class VirtualNetworkApplianceManagerImpl extends ManagerBase implements V
private static final String FILESYSTEM_WRITABLE_TEST = "filesystem.writable.test";
private static final String READONLY_FILESYSTEM_ERROR = "Read-only file system";
private static final String BACKUP_ROUTER_EXCLUDED_TESTS = "gateways_check.py";
+ /**
+ * Used regex to ensure that the value that will be passed to the VR is an acceptable value
Review Comment:
```suggestion
* Regex used to ensure that the value that will be passed to the VR is an acceptable value.
```
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,13 +2131,33 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ if (!checkLogrotateTimerPattern(routerLogrotateFrequency)) {
+ s_logger.debug(String.format("Setting [%s] with value [%s] do not match with the used regex [%s], or any acceptable value ('hourly', 'daily', 'monthly'); " +
+ "therefore, we will use the default value [%s] to configure the logrotate service on the virtual router.",RouterLogrotateFrequency.key(),
Review Comment:
```suggestion
"therefore, we will use the default value [%s] to configure the logrotate service on the virtual router.", RouterLogrotateFrequency.key(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1200415543
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1169593739
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 3671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1169109454
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1179646468
<b>Trillian test result (tid-4473)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37253 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6507-t4473-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1206278541
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r938857611
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,6 +2126,11 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s], will be used to configure the logrotate service frequency" +
+ " on the virtual router.", RouterLogrotateFrequency.key(), routerLogrotateFrequency, dc.getUuid()));
+ buf.append(String.format(" logrotatefrequency=%s", routerLogrotateFrequency));
Review Comment:
@DaanHoogland yes
@RodrigoDLopez
have you tested with a random string ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1169532344
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r935886240
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,6 +2126,11 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s], will be used to configure the logrotate service frequency" +
+ " on the virtual router.", RouterLogrotateFrequency.key(), routerLogrotateFrequency, dc.getUuid()));
+ buf.append(String.format(" logrotatefrequency=%s", routerLogrotateFrequency));
Review Comment:
I did not test with nonsense values, just the value of `null`, in this case, the default value will be applied and some values that make any sense, so I am not sure if a nonsense value will break logrotate service.
any suggestion to ensure that the operators will follow the pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1209145131
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1232551163
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1232605743
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1253454734
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1281171608
<b>Trillian Build Failed (tid-5159)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1277115753
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r912904709
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,6 +2126,11 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s], will be used to configure the logrotate service frequency" +
+ " on the virtual router.", RouterLogrotateFrequency.key(), routerLogrotateFrequency, dc.getUuid()));
Review Comment:
```suggestion
if (s_logger.isDebugEnabled()) {
s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s], will be used to configure the logrotate service frequency" +
" on the virtual router.", RouterLogrotateFrequency.key(), routerLogrotateFrequency, dc.getUuid()));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1253554866
<b>Trillian Build Failed (tid-4949)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1290430371
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1275715313
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1280571516
<b>Trillian Build Failed (tid-5150)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1290168492
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1283965114
<b>Trillian Build Failed (tid-5171)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1272245124
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1169116877
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6507 (SL-JID-1867)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1199839303
is there anything else missing in this one? or we are good to go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r934340728
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,6 +2126,11 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s], will be used to configure the logrotate service frequency" +
+ " on the virtual router.", RouterLogrotateFrequency.key(), routerLogrotateFrequency, dc.getUuid()));
+ buf.append(String.format(" logrotatefrequency=%s", routerLogrotateFrequency));
Review Comment:
@RodrigoDLopez
is there a check on the value so that the logrotate will not be broken due to invalid value ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1200405920
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1200417096
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1200423542
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1232550512
ah, I think this is good to go. let's re-run the smoke tests.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1208146594
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r939535963
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,6 +2126,11 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
}
}
+ String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+ s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s], will be used to configure the logrotate service frequency" +
+ " on the virtual router.", RouterLogrotateFrequency.key(), routerLogrotateFrequency, dc.getUuid()));
+ buf.append(String.format(" logrotatefrequency=%s", routerLogrotateFrequency));
Review Comment:
@weizhouapache
I was able to confirm that even when the operator enters a meaningless value, the Logrotate service continues to run. However, I was not able to identify which frequency value was assumed in this context. For this reason, a new method was implemented to check if the value provided makes sense, otherwise, we will use the default value. Can you please review it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1207226645
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1207234502
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6507)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6507&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6507&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6507&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6507: Externalizes logrotate service frequency timer in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#issuecomment-1207227253
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6507 (SL-JID-2093)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org