You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Syed Albiz <s....@gmail.com> on 2011/08/02 04:35:11 UTC
Review Request: HIVE-2138: Exception when no splits returned from index
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1255/
-----------------------------------------------------------
Review request for hive, John Sichi and Yongqiang He.
Summary
-------
return an empty array of input splits when we get back no results from the hiveIndexResult
This addresses bug HIVE-2138.
https://issues.apache.org/jira/browse/HIVE-2138
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java 1a1ecd7
ql/src/test/queries/clientpositive/index_auto_test_if_used.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_test_if_used.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1255/diff
Testing
-------
added index_auto_test_if_used.q to the test suite
Thanks,
Syed
Re: Review Request: HIVE-2138: Exception when no splits returned from index
Posted by John Sichi <js...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1255/#review1265
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java
<https://reviews.apache.org/r/1255/#comment2898>
We're not actually generating a dummy file now...
ql/src/test/queries/clientpositive/index_auto_test_if_used.q
<https://reviews.apache.org/r/1255/#comment2900>
Could you add a note that this test relies on the fact that we currently attempt to use indexes even when they are out of date, and that once we fix that by detecting stale indexes, we'll need another way to verify that the index actually had an effect?
ql/src/test/queries/clientpositive/index_auto_test_if_used.q
<https://reviews.apache.org/r/1255/#comment2899>
Reissue query to demonstrate that results are returned after index lookup is disabled.
- John
On 2011-08-02 02:35:11, Syed Albiz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1255/
> -----------------------------------------------------------
>
> (Updated 2011-08-02 02:35:11)
>
>
> Review request for hive, John Sichi and Yongqiang He.
>
>
> Summary
> -------
>
> return an empty array of input splits when we get back no results from the hiveIndexResult
>
>
> This addresses bug HIVE-2138.
> https://issues.apache.org/jira/browse/HIVE-2138
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java 1a1ecd7
> ql/src/test/queries/clientpositive/index_auto_test_if_used.q PRE-CREATION
> ql/src/test/results/clientpositive/index_auto_test_if_used.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/1255/diff
>
>
> Testing
> -------
>
> added index_auto_test_if_used.q to the test suite
>
>
> Thanks,
>
> Syed
>
>
Re: Review Request: HIVE-2138: Exception when no splits returned from index
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1255/
-----------------------------------------------------------
(Updated 2011-08-05 19:05:05.682867)
Review request for hive, John Sichi and Yongqiang He.
Changes
-------
updated testcases with new output
Summary
-------
return an empty array of input splits when we get back no results from the hiveIndexResult
This addresses bug HIVE-2138.
https://issues.apache.org/jira/browse/HIVE-2138
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java 1a1ecd7
ql/src/test/queries/clientpositive/index_auto_empty.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_empty.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1255/diff
Testing
-------
added index_auto_test_if_used.q to the test suite
Thanks,
Syed
Re: Review Request: HIVE-2138: Exception when no splits returned from index
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1255/
-----------------------------------------------------------
(Updated 2011-08-04 21:56:31.633797)
Review request for hive, John Sichi and Yongqiang He.
Changes
-------
removed stale testcase
Summary
-------
return an empty array of input splits when we get back no results from the hiveIndexResult
This addresses bug HIVE-2138.
https://issues.apache.org/jira/browse/HIVE-2138
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java 1a1ecd7
ql/src/test/queries/clientpositive/index_auto_empty.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_empty.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1255/diff
Testing
-------
added index_auto_test_if_used.q to the test suite
Thanks,
Syed
Re: Review Request: HIVE-2138: Exception when no splits returned from index
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1255/
-----------------------------------------------------------
(Updated 2011-08-02 23:44:30.658334)
Review request for hive, John Sichi and Yongqiang He.
Changes
-------
replace test case with something more robust
Summary
-------
return an empty array of input splits when we get back no results from the hiveIndexResult
This addresses bug HIVE-2138.
https://issues.apache.org/jira/browse/HIVE-2138
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java 1a1ecd7
ql/src/test/queries/clientpositive/index_auto_empty.q PRE-CREATION
ql/src/test/queries/clientpositive/index_auto_test_if_used.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_empty.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1255/diff
Testing
-------
added index_auto_test_if_used.q to the test suite
Thanks,
Syed
Re: Review Request: HIVE-2138: Exception when no splits returned from index
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1255/
-----------------------------------------------------------
(Updated 2011-08-02 18:48:23.995744)
Review request for hive, John Sichi and Yongqiang He.
Changes
-------
addressed comments
Summary
-------
return an empty array of input splits when we get back no results from the hiveIndexResult
This addresses bug HIVE-2138.
https://issues.apache.org/jira/browse/HIVE-2138
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java 1a1ecd7
ql/src/test/queries/clientpositive/index_auto_test_if_used.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_test_if_used.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1255/diff
Testing
-------
added index_auto_test_if_used.q to the test suite
Thanks,
Syed