You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Nino Martinez (JIRA)" <ji...@apache.org> on 2008/08/20 23:46:44 UTC

[jira] Created: (WICKET-1795) Make it possible for to encode unicode strings in component

Make it possible for to encode unicode strings in component
-----------------------------------------------------------

                 Key: WICKET-1795
                 URL: https://issues.apache.org/jira/browse/WICKET-1795
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.3.4
            Reporter: Nino Martinez
             Fix For: 1.3.5
         Attachments: wicketComponentEncoding.patch

It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (WICKET-1795) Make it possible for to encode unicode strings in component

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner reopened WICKET-1795:
-------------------------------------


> Make it possible for to encode unicode strings in component
> -----------------------------------------------------------
>
>                 Key: WICKET-1795
>                 URL: https://issues.apache.org/jira/browse/WICKET-1795
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.3.5
>
>         Attachments: wicketComponentEncoding.patch
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell. 
> Additionally im not sure what goes for the wicket:message tag? It would be very nice to have a switch in markupsettings to decide all encoding.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-1795) Make it possible for to encode unicode strings in component

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-1795.
-----------------------------------

    Resolution: Won't Fix

> Make it possible for to encode unicode strings in component
> -----------------------------------------------------------
>
>                 Key: WICKET-1795
>                 URL: https://issues.apache.org/jira/browse/WICKET-1795
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.3.5
>
>         Attachments: wicketComponentEncoding.patch
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell. 
> Additionally im not sure what goes for the wicket:message tag? It would be very nice to have a switch in markupsettings to decide all encoding.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1795) Make it possible for to encode unicode strings in component

Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633447#action_12633447 ] 

Martijn Dashorst commented on WICKET-1795:
------------------------------------------

the non-ascii characters should not be in the markup file because they are encoded differently on different operating systems. The escape non-escaping markup test is therefore not possible to convert :S

> Make it possible for to encode unicode strings in component
> -----------------------------------------------------------
>
>                 Key: WICKET-1795
>                 URL: https://issues.apache.org/jira/browse/WICKET-1795
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.3.5
>
>         Attachments: wicketComponentEncoding.patch
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell. 
> Additionally im not sure what goes for the wicket:message tag? It would be very nice to have a switch in markupsettings to decide all encoding.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1795) Make it possible for to encode unicode strings in component

Posted by "Nino Martinez (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nino Martinez updated WICKET-1795:
----------------------------------

       Priority: Minor  (was: Major)
    Description: 
It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell. 

Additionally im not sure what goes for the wicket:message tag? It would be very nice to have a switch in markupsettings to decide all encoding.

  was:It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell


Not major priority..

> Make it possible for to encode unicode strings in component
> -----------------------------------------------------------
>
>                 Key: WICKET-1795
>                 URL: https://issues.apache.org/jira/browse/WICKET-1795
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.3.5
>
>         Attachments: wicketComponentEncoding.patch
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell. 
> Additionally im not sure what goes for the wicket:message tag? It would be very nice to have a switch in markupsettings to decide all encoding.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1795) Make it possible for to encode unicode strings in component

Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635251#action_12635251 ] 

Timo Rantalaiho commented on WICKET-1795:
-----------------------------------------

Martijn, surely you can have non-ASCII characters in the markup file as long as you ensure that the markup file will be read with the correct encoding (for example, by setting the "file.encoding" system property to "utf-8"). In many minor languages, such as Finnish, this makes a lot of sense -- for example, "instructions of use" in Finnish would be "Käyttöohje" written with a common encoding that has more than just ASCII (such as UTF-8 or ISO-Latin-1 or ISO-Latin-9 or cp1252), but "K&auml;ytt&ouml;ohje" in the escaped form. It's very handy to have the readable form everywhere, these character entity encodings are a thing of the past century to me :)

Nino, can this issue be closed?

> Make it possible for to encode unicode strings in component
> -----------------------------------------------------------
>
>                 Key: WICKET-1795
>                 URL: https://issues.apache.org/jira/browse/WICKET-1795
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.3.5
>
>         Attachments: wicketComponentEncoding.patch
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell. 
> Additionally im not sure what goes for the wicket:message tag? It would be very nice to have a switch in markupsettings to decide all encoding.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1795) Make it possible for to encode unicode strings in component

Posted by "Nino Martinez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633548#action_12633548 ] 

Nino Martinez commented on WICKET-1795:
---------------------------------------

hmm did'nt think of that.:(

> Make it possible for to encode unicode strings in component
> -----------------------------------------------------------
>
>                 Key: WICKET-1795
>                 URL: https://issues.apache.org/jira/browse/WICKET-1795
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.3.5
>
>         Attachments: wicketComponentEncoding.patch
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell. 
> Additionally im not sure what goes for the wicket:message tag? It would be very nice to have a switch in markupsettings to decide all encoding.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-1795) Make it possible for to encode unicode strings in component

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-1795.
-----------------------------------

    Resolution: Fixed

closing this one for now
Why would you encode it by the way? Just serve it as UTF-8 which is the default in wicket anyway then you dont really need to encode it

The whole world should listen to me for one time and switch over to UTF-8 now and drop all other charsets



> Make it possible for to encode unicode strings in component
> -----------------------------------------------------------
>
>                 Key: WICKET-1795
>                 URL: https://issues.apache.org/jira/browse/WICKET-1795
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.3.5
>
>         Attachments: wicketComponentEncoding.patch
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell. 
> Additionally im not sure what goes for the wicket:message tag? It would be very nice to have a switch in markupsettings to decide all encoding.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1795) Make it possible for to encode unicode strings in component

Posted by "Nino Martinez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633551#action_12633551 ] 

Nino Martinez commented on WICKET-1795:
---------------------------------------

Argh, did'nt think of that.. :/



> Make it possible for to encode unicode strings in component
> -----------------------------------------------------------
>
>                 Key: WICKET-1795
>                 URL: https://issues.apache.org/jira/browse/WICKET-1795
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.3.5
>
>         Attachments: wicketComponentEncoding.patch
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell. 
> Additionally im not sure what goes for the wicket:message tag? It would be very nice to have a switch in markupsettings to decide all encoding.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1795) Make it possible for to encode unicode strings in component

Posted by "Nino Martinez (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nino Martinez updated WICKET-1795:
----------------------------------

    Attachment: wicketComponentEncoding.patch

My attempt to solve this

> Make it possible for to encode unicode strings in component
> -----------------------------------------------------------
>
>                 Key: WICKET-1795
>                 URL: https://issues.apache.org/jira/browse/WICKET-1795
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>            Reporter: Nino Martinez
>             Fix For: 1.3.5
>
>         Attachments: wicketComponentEncoding.patch
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.