You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2026/10/19 09:59:19 UTC
[PR] GH-54595: [Packaging][CI] Fix regex on update_deb_package_names to cover the 3 on libarrow_s3 [arrow]
raulcd opened a new pull request, #54608:
URL: https://github.com/apache/arrow/pull/54608
### Rationale for this change
Linux packaging jobs for Deb packages are currently failing due to wrong libarrow_s32600 still being referred to.
### What changes are included in this PR?
Update regex to cover numbers on libarrowxxx package names.
Update the wrong entries at control.in.
### Are these changes tested?
I have tested the regex locally with:
```
$ sed -i.bak -E -e "s/(lib(arrow|gandiva|parquet)[-a-z0-9]*)2700/\\12800/g" dev/tasks/linux-packages/apache-arrow/debian/control.in
```
And validated the diff contains libarrow s3 updated:
```diff
@@ -122,13 +122,13 @@ Pre-Depends: ${misc:Pre-Depends}
Depends:
${misc:Depends},
${shlibs:Depends},
- libarrow-acero2700 (= ${binary:Version}),
- libparquet2700 (= ${binary:Version})
+ libarrow-acero2800 (= ${binary:Version}),
+ libparquet2800 (= ${binary:Version})
Description: Apache Arrow is a data processing library for analysis
.
This package provides C++ library files for Dataset module.
-Package: libarrow-s3-2700
+Package: libarrow-s3-2800
Section: libs
Architecture: any
Multi-Arch: same
```
### Are there any user-facing changes?
No
### Was AI used for this PR?
In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR.
**PR code and description written by:**
- [x] Human
- [ ] AI
**Reviewed before submission by:**
- [x] Human
- [ ] AI
- [ ] Not reviewed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-54595: [Packaging][CI] Fix regex on update_deb_package_names to cover the 3 on libarrow_s3 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #54608:
URL: https://github.com/apache/arrow/pull/54608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-54595: [Packaging][CI] Fix regex on update_deb_package_names to cover the 3 on libarrow_s3 [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #54608:
URL: https://github.com/apache/arrow/pull/54608#discussion_r4314600026
##########
dev/release/utils-prepare.sh:
##########
@@ -216,7 +216,7 @@ update_deb_package_names() {
${target} \
$(echo ${target} | sed -e "s/${deb_lib_suffix}/${next_deb_lib_suffix}/")
done
- local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g"
+ local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z0-9]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g"
Review Comment:
@kou this should be covered now on: https://github.com/apache/arrow/pull/54608/changes/5fcef5d75d38cf0b92a74a9a38aa32c1cba881df
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-54595: [Packaging][CI] Fix regex on update_deb_package_names to cover the 3 on libarrow_s3 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #54608:
URL: https://github.com/apache/arrow/pull/54608#discussion_r4320544039
##########
dev/release/utils-prepare.sh:
##########
@@ -216,7 +216,7 @@ update_deb_package_names() {
${target} \
$(echo ${target} | sed -e "s/${deb_lib_suffix}/${next_deb_lib_suffix}/")
done
- local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g"
+ local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z0-9]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g"
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-54595: [Packaging][CI] Fix regex on update_deb_package_names to cover the 3 on libarrow_s3 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #54608:
URL: https://github.com/apache/arrow/pull/54608#discussion_r4313746746
##########
dev/release/utils-prepare.sh:
##########
@@ -216,7 +216,7 @@ update_deb_package_names() {
${target} \
$(echo ${target} | sed -e "s/${deb_lib_suffix}/${next_deb_lib_suffix}/")
done
- local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g"
+ local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z0-9]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g"
Review Comment:
Could you also update https://github.com/apache/arrow/blob/fb767a7cae8a52bd52166628b73353d3d85ca88f/dev/release/utils-prepare.sh#L236 ? We will add `gir1.2-arrow-s3-27.0.install` later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org