You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Vikas Saurabh (JIRA)" <ji...@apache.org> on 2017/02/15 13:55:41 UTC
[jira] [Resolved] (OAK-5626) ChangeProcessor doesn't reset
'blocking' flag when items from queue gets removed and commit-rate-limiter
is null
[ https://issues.apache.org/jira/browse/OAK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Saurabh resolved OAK-5626.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.8
1.7.0
Fixed on trunk at [r1783104|https://svn.apache.org/r1783104].
The logs from {{warnOnRepeatedQueueFull}} look like:
{noformat}
19:22:03.042 WARN [main] ChangeProcessor.java:374 Revision queue is full. Further revisions will be compacted. Suppressing further such cases for 600 seconds.
19:22:03.071 DEBUG [main] ChangeProcessor.java:379 Revision queue is full. Further revisions will be compacted.
19:22:03.109 WARN [main] ChangeProcessor.java:374 Revision queue is full. Further revisions will be compacted. Suppressing further such cases for 600 seconds.
{noformat}
> ChangeProcessor doesn't reset 'blocking' flag when items from queue gets removed and commit-rate-limiter is null
> ----------------------------------------------------------------------------------------------------------------
>
> Key: OAK-5626
> URL: https://issues.apache.org/jira/browse/OAK-5626
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Vikas Saurabh
> Assignee: Vikas Saurabh
> Priority: Minor
> Fix For: 1.7.0, 1.8
>
> Attachments: OAK-5626.patch, OAK-5626-v2.patch, OAK-5626-v3.patch
>
>
> Following up on conversation at \[0]:
> {{ChangeProcessor#queueSizeChanged}} \[1] sets blocking flag to true if queue size is hit (or beyond). The warning "Revision queue is full. Further revisions will be compacted." is logged only when it *wasn't* blocking.
> BUT, when queue empties, blocking flag is reset inside if block for commitRateLimiter!=null. That means an event chain like:
> # qFull
> # log warn
> # qEmpties
> # qFull
> won't log the WARN after step(4)
> \[0]: http://markmail.org/message/hgein5g3ohyjhw5n
> \[1]: https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/observation/ChangeProcessor.java#L307
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)