You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/30 19:36:19 UTC
[GitHub] [airflow] mik-laj opened a new pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
mik-laj opened a new pull request #9596:
URL: https://github.com/apache/airflow/pull/9596
I'm starting work on preparing a patch for the master branch as well.
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Target Github ISSUE in description if exists
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#issuecomment-652443343
> @kaxil I made the necessary changes to make the tests stable and did rebase.
Thanks, I will merge as soon as the CI is complete
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #9596:
URL: https://github.com/apache/airflow/pull/9596
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#issuecomment-652353000
212 commits -- something has gone wrong with this PR (so we can't review it)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#issuecomment-652028965
@potiuk I fixed it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#issuecomment-652104618
@kaxil I know :_;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#issuecomment-652102215
Tests are still failing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#discussion_r448430604
##########
File path: requirements/requirements-python3.8.txt
##########
@@ -50,7 +50,7 @@ aws-xray-sdk==2.6.0
azure-common==1.1.25
azure-cosmos==3.1.2
azure-datalake-store==0.0.48
-azure-mgmt-containerinstance==1.5.0
+azure-mgmt-containerinstance==2.0.0
Review comment:
It broke my build. I'm working on a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb edited a comment on pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#issuecomment-652353000
212 commits -- something has gone wrong with this PR (so we can't review it)
Looking at last commit https://github.com/apache/airflow/commit/8d75bfec0d32c39d61ddded170e05ab20367a8ba this looks okay though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#issuecomment-652108938
@kaxil We have Python 3.8 compatibility issues: https://apache-airflow.slack.com/archives/CCPRP7943/p1593558215208800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#issuecomment-652450871
I forgot to generate requirements for Python 3.5. I'm working on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#issuecomment-652105758
> @kaxil I know :_;
:D Although all the tests in v1-10-test passed: https://github.com/apache/airflow/commits/v1-10-test (https://github.com/apache/airflow/runs/824432425)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#issuecomment-652353949
Sorry, it was because I force-pushed v1-10-test to remove all fixups as we are almost ready
Can you please rebase on latest v1-10-test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#discussion_r448455220
##########
File path: requirements/requirements-python3.8.txt
##########
@@ -50,7 +50,7 @@ aws-xray-sdk==2.6.0
azure-common==1.1.25
azure-cosmos==3.1.2
azure-datalake-store==0.0.48
-azure-mgmt-containerinstance==1.5.0
+azure-mgmt-containerinstance==2.0.0
Review comment:
I just pushed a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9596: Fix quarantined tests - TestCliWebServer (v1-10-test)
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9596:
URL: https://github.com/apache/airflow/pull/9596#issuecomment-652431804
@kaxil I made the necessary changes to make the tests stable and did rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org