You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smengcl (via GitHub)" <gi...@apache.org> on 2023/03/23 20:05:15 UTC

[GitHub] [ozone] smengcl opened a new pull request, #4462: HDDS-8263. [JDK17] Bump guice to 5.1.0, maven-shade-plugin to 3.4.1, remove guice-multibindings

smengcl opened a new pull request, #4462:
URL: https://github.com/apache/ozone/pull/4462

   ## What changes were proposed in this pull request?
   
   In order to support compilation of Ozone under JDK 17, the following changes are required:
   
   - Bump maven-shade-plugin to 3.4.1
   - Bump guice to 5.1.0
     - Remove guice-multibindings (no longer exists since guice 5.0.0)
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-8263
   
   ## How was this patch tested?
   
   - Compilation passed with JDK 17 on CI on my fork's [other test branch](https://github.com/smengcl/hadoop-ozone/commits/HDDS-8248-jdk17-compile)
     - https://github.com/smengcl/hadoop-ozone/actions/runs/4497681697/jobs/7913886545
   - Compilation passed locally with Zulu JDK 1.8.0_362 aarch64
   - Compilation should pass in this PR CI with JDK 11 (unchanged)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smengcl commented on pull request #4462: HDDS-8263. [JDK17] Bump guice to 5.1.0, maven-shade-plugin to 3.4.1, remove guice-multibindings

Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #4462:
URL: https://github.com/apache/ozone/pull/4462#issuecomment-1483552754

   Thanks @adoroszlai for reviewing and merging this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai merged pull request #4462: HDDS-8263. [JDK17] Bump guice to 5.1.0, maven-shade-plugin to 3.4.1, remove guice-multibindings

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4462:
URL: https://github.com/apache/ozone/pull/4462


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org