[GitHub] [spark] HyukjinKwon commented on a change in pull request #34545: [SPARK-37268][SQL] Remove unused method call in FileScanRDD

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34545:
URL: https://github.com/apache/spark/pull/34545#discussion_r747138602



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
##########
@@ -107,7 +107,6 @@ class FileScanRDD(
         val nextElement = currentIterator.next()
         // TODO: we should have a better separation of row based and batch based scan, so that we
         // don't need to run this `if` for every record.
-        val preNumRecordsRead = inputMetrics.recordsRead

Review comment:
       Looks fine but it would have been better which PR removed the last usage of this in order to make any mistake.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org