You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by le...@apache.org on 2022/07/29 03:56:18 UTC
[datasketches-java] 06/08: Merge branch 'minor_changes_to_REQ' into Changes_to_kll
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a commit to branch More_changes_to_REQ
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit 889c820b8845f5de95c121aac2f80c5cee054cbc
Merge: 1436f378 ad19fb65
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Tue Jul 26 19:44:04 2022 -0700
Merge branch 'minor_changes_to_REQ' into Changes_to_kll
README.md | 6 ++++-
.../kll/KllDoublesSketchSortedView.java | 27 ++++++++++++++++++----
.../kll/KllFloatsSketchSortedView.java | 27 ++++++++++++++++++----
.../KllQuantilesHelper.java} | 11 +++++----
.../ClassicQuantilesHelper.java} | 10 +++++---
.../quantiles/DoublesSketchSortedView.java | 27 +++++++++++++++++-----
.../quantiles/ItemsSketchSortedView.java | 27 +++++++++++++++++-----
.../org/apache/datasketches/req/BaseReqSketch.java | 2 +-
.../datasketches/req/ReqSketchSortedView.java | 19 +++++++++++++--
.../req/ReqSketchSortedViewIterator.java | 5 ++--
.../datasketches/CrossCheckQuantilesTest.java | 2 +-
.../datasketches/kll/KllFloatsSketchTest.java | 2 +-
.../quantiles/HeapUpdateDoublesSketchTest.java | 4 ++--
.../org/apache/datasketches/req/ReqSketchTest.java | 3 ++-
14 files changed, 132 insertions(+), 40 deletions(-)
diff --cc src/main/java/org/apache/datasketches/kll/KllFloatsSketchSortedView.java
index f3359da5,9a2c0b24..2ea3d15a
--- a/src/main/java/org/apache/datasketches/kll/KllFloatsSketchSortedView.java
+++ b/src/main/java/org/apache/datasketches/kll/KllFloatsSketchSortedView.java
@@@ -21,8 -21,6 +21,7 @@@ package org.apache.datasketches.kll
import java.util.Arrays;
- import org.apache.datasketches.QuantilesHelper;
+import org.apache.datasketches.SketchesArgumentException;
import org.apache.datasketches.SketchesStateException;
/**
diff --cc src/test/java/org/apache/datasketches/kll/KllFloatsSketchTest.java
index 073d562c,cb1951ff..a2d97dd9
--- a/src/test/java/org/apache/datasketches/kll/KllFloatsSketchTest.java
+++ b/src/test/java/org/apache/datasketches/kll/KllFloatsSketchTest.java
@@@ -126,7 -125,7 +126,7 @@@ public class KllFloatsSketchTest
assertEquals(sketch.getQuantile(0.7, true), 7);
assertEquals(sketch.getQuantile(0.8, true), 8);
assertEquals(sketch.getQuantile(0.9, true), 9);
-- assertEquals(sketch.getQuantile(1, true), 10); // always max value
++ assertEquals(sketch.getQuantile(1, true), 10); // always max value TODO
// getQuantile() and getQuantiles() equivalence
{
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org