You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/19 04:16:16 UTC
[GitHub] [flink] lirui-apache opened a new pull request #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
lirui-apache opened a new pull request #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Add black list for Hive built-in functions
## Brief change log
- Add black list for Hive built-in functions
- Add test case
## Verifying this change
New test
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? NA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145096925 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145101343 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
Hash:ed8c501debf28c71890386f3f360b5c840b2ab48 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ed8c501debf28c71890386f3f360b5c840b2ab48
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
* 5adc6ab35ccc1a53562983afb90d7212dcf66a1c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145096925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462)
* 7770f4164715b32effda6810dfa2eb64b3d5a539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145101343) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468)
* ed8c501debf28c71890386f3f360b5c840b2ab48 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145096925 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
* 5adc6ab35ccc1a53562983afb90d7212dcf66a1c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145096925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145096925 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
* 5adc6ab35ccc1a53562983afb90d7212dcf66a1c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145096925) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145096925 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145101343 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
* 5adc6ab35ccc1a53562983afb90d7212dcf66a1c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145096925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462)
* 7770f4164715b32effda6810dfa2eb64b3d5a539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145101343) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on issue #10894: [FLINK-15592][hive]
Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-577789535
LGTM, merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145096925 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145101343 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
Hash:ed8c501debf28c71890386f3f360b5c840b2ab48 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145168191 TriggerType:PUSH TriggerID:ed8c501debf28c71890386f3f360b5c840b2ab48
Hash:ed8c501debf28c71890386f3f360b5c840b2ab48 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4496 TriggerType:PUSH TriggerID:ed8c501debf28c71890386f3f360b5c840b2ab48
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
* 5adc6ab35ccc1a53562983afb90d7212dcf66a1c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145096925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462)
* 7770f4164715b32effda6810dfa2eb64b3d5a539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145101343) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468)
* ed8c501debf28c71890386f3f360b5c840b2ab48 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145168191) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4496)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145096925 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145101343 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
Hash:ed8c501debf28c71890386f3f360b5c840b2ab48 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145168191 TriggerType:PUSH TriggerID:ed8c501debf28c71890386f3f360b5c840b2ab48
Hash:ed8c501debf28c71890386f3f360b5c840b2ab48 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4496 TriggerType:PUSH TriggerID:ed8c501debf28c71890386f3f360b5c840b2ab48
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
* 5adc6ab35ccc1a53562983afb90d7212dcf66a1c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145096925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462)
* 7770f4164715b32effda6810dfa2eb64b3d5a539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145101343) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468)
* ed8c501debf28c71890386f3f360b5c840b2ab48 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145168191) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4496)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #10894: [FLINK-15592][hive]
Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575965613
cc @JingsongLi @bowenli86
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145096925 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145101343 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
* 5adc6ab35ccc1a53562983afb90d7212dcf66a1c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145096925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462)
* 7770f4164715b32effda6810dfa2eb64b3d5a539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145101343) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145096925 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
* 5adc6ab35ccc1a53562983afb90d7212dcf66a1c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145096925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462)
* 7770f4164715b32effda6810dfa2eb64b3d5a539 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10894: [FLINK-15592][hive] Add
black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10894: [FLINK-15592][hive]
Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-577612888
> @JingsongLi Are you merging this?
I want to... but I am not a committer, since it is a critical issue in 1.10. I will CC @wuchong to help merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#discussion_r368386963
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV120.java
##########
@@ -47,6 +51,14 @@
*/
public class HiveShimV120 extends HiveShimV111 {
+ // a set of functions that shouldn't be overridden by HiveModule
+ @VisibleForTesting
+ public static final Set<String> BUILT_IN_FUNC_BLACKLIST = Collections.unmodifiableSet(new HashSet<>(
Review comment:
I put it in the shim so that the filter is closer to the source. But I'm also fine to move it to HiveModule to make things clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #10894: [FLINK-15592][hive] Add
black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-577600843
@JingsongLi Are you merging this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145096925 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145101343 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
Hash:ed8c501debf28c71890386f3f360b5c840b2ab48 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145168191 TriggerType:PUSH TriggerID:ed8c501debf28c71890386f3f360b5c840b2ab48
Hash:ed8c501debf28c71890386f3f360b5c840b2ab48 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4496 TriggerType:PUSH TriggerID:ed8c501debf28c71890386f3f360b5c840b2ab48
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
* 5adc6ab35ccc1a53562983afb90d7212dcf66a1c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145096925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462)
* 7770f4164715b32effda6810dfa2eb64b3d5a539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145101343) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468)
* ed8c501debf28c71890386f3f360b5c840b2ab48 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145168191) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4496)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
* 5adc6ab35ccc1a53562983afb90d7212dcf66a1c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10894: [FLINK-15592][hive] Add
black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575965721
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a72e031a0f93df6cf782968234f59a9ba0c40821 (Sun Jan 19 04:19:25 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on a change in pull request #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on a change in pull request #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#discussion_r368324020
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV120.java
##########
@@ -47,6 +51,14 @@
*/
public class HiveShimV120 extends HiveShimV111 {
+ // a set of functions that shouldn't be overridden by HiveModule
+ @VisibleForTesting
+ public static final Set<String> BUILT_IN_FUNC_BLACKLIST = Collections.unmodifiableSet(new HashSet<>(
Review comment:
should this be in HiveModule rather than hive shim?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#issuecomment-575966596
<!--
Meta data
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145094605 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:a72e031a0f93df6cf782968234f59a9ba0c40821 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459 TriggerType:PUSH TriggerID:a72e031a0f93df6cf782968234f59a9ba0c40821
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145096925 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:5adc6ab35ccc1a53562983afb90d7212dcf66a1c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462 TriggerType:PUSH TriggerID:5adc6ab35ccc1a53562983afb90d7212dcf66a1c
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145101343 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
Hash:7770f4164715b32effda6810dfa2eb64b3d5a539 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468 TriggerType:PUSH TriggerID:7770f4164715b32effda6810dfa2eb64b3d5a539
-->
## CI report:
* a72e031a0f93df6cf782968234f59a9ba0c40821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145094605) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4459)
* 5adc6ab35ccc1a53562983afb90d7212dcf66a1c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145096925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4462)
* 7770f4164715b32effda6810dfa2eb64b3d5a539 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145101343) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4468)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 closed pull request #10894: [FLINK-15592][hive]
Add black list for Hive built-in functions
Posted by GitBox <gi...@apache.org>.
bowenli86 closed pull request #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services