You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2024/12/30 09:47:15 UTC
[PR] Handling SystemExit from task sdk [airflow]
amoghrajesh opened a new pull request, #45282:
URL: https://github.com/apache/airflow/pull/45282
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
PR: #45106 provides a machinery to handle "failure" / "retry" states in the execution API server itself.
The aim of this PR is to extend to the "SystemExit" exception if thrown by tasks.
## Testing results
### DAG used (with and without retries):
```
import sys
from time import sleep
from airflow import DAG
from airflow.providers.standard.operators.python import PythonOperator
def print_hello():
sleep(10)
print("exiting with code 10")
exit(10)
with DAG(
dag_id="exitcode",
schedule=None,
catchup=False,
tags=["demo"],
) as dag:
hello_task = PythonOperator(
task_id="exitcode-task",
retries=2,
python_callable=print_hello,
)
```
### Behaviour in legacy (non task sdk):
With retries configured
Without retries configured
<img width="1719" alt="image" src="https://github.com/user-attachments/assets/76657e18-a3ec-47ef-b32f-eca351f8b7a3" />
<img width="1719" alt="image" src="https://github.com/user-attachments/assets/e66d4cb9-dbf0-468f-98cd-584128bd72ab" />
### Behaviour in task sdk:
With retries configured
Without retries configured
<img width="1719" alt="image" src="https://github.com/user-attachments/assets/b94be24e-75c4-4cbc-8aab-f020a4dc0a45" />
<img width="1719" alt="image" src="https://github.com/user-attachments/assets/00797a5a-5954-418b-b6b4-dcc5f9f61ff0" />
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-72: Handling SystemExit from task sdk [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #45282:
URL: https://github.com/apache/airflow/pull/45282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-72: Handling SystemExit from task sdk [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #45282:
URL: https://github.com/apache/airflow/pull/45282#discussion_r1899433271
##########
task_sdk/tests/execution_time/test_task_runner.py:
##########
@@ -295,6 +295,47 @@ def test_run_raises_base_exception(time_machine, mocked_parse, make_ti_context):
)
+def test_run_raises_system_exit(time_machine, mocked_parse, make_ti_context):
+ """Test running a basic task that exits with SystemExit exception."""
+ from airflow.providers.standard.operators.python import PythonOperator
+
+ task = PythonOperator(
+ task_id="system_exit_task",
+ python_callable=lambda: exit(10),
+ )
+
+ what = StartupDetails(
+ ti=TaskInstance(
+ id=uuid7(),
+ task_id="system_exit_task",
+ dag_id="basic_dag_system_exit",
+ run_id="c",
+ try_number=1,
+ ),
+ file="",
+ requests_fd=0,
+ ti_context=make_ti_context(),
+ )
+
+ ti = mocked_parse(what, "basic_dag_system_exit", task)
+
+ instant = timezone.datetime(2024, 12, 3, 10, 0)
+ time_machine.move_to(instant, tick=False)
+
+ with mock.patch(
+ "airflow.sdk.execution_time.task_runner.SUPERVISOR_COMMS", create=True
+ ) as mock_supervisor_comms:
Review Comment:
Alright, yeah, didn't realise it was added in #45245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-72: Handling SystemExit from task sdk [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #45282:
URL: https://github.com/apache/airflow/pull/45282#discussion_r1899430442
##########
task_sdk/tests/execution_time/test_task_runner.py:
##########
@@ -295,6 +295,47 @@ def test_run_raises_base_exception(time_machine, mocked_parse, make_ti_context):
)
+def test_run_raises_system_exit(time_machine, mocked_parse, make_ti_context):
+ """Test running a basic task that exits with SystemExit exception."""
+ from airflow.providers.standard.operators.python import PythonOperator
+
+ task = PythonOperator(
+ task_id="system_exit_task",
+ python_callable=lambda: exit(10),
+ )
+
+ what = StartupDetails(
+ ti=TaskInstance(
+ id=uuid7(),
+ task_id="system_exit_task",
+ dag_id="basic_dag_system_exit",
+ run_id="c",
+ try_number=1,
+ ),
+ file="",
+ requests_fd=0,
+ ti_context=make_ti_context(),
+ )
+
+ ti = mocked_parse(what, "basic_dag_system_exit", task)
+
+ instant = timezone.datetime(2024, 12, 3, 10, 0)
+ time_machine.move_to(instant, tick=False)
+
+ with mock.patch(
+ "airflow.sdk.execution_time.task_runner.SUPERVISOR_COMMS", create=True
+ ) as mock_supervisor_comms:
Review Comment:
Just use the mock_supervisor_comms fixture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-72: Handling SystemExit from task sdk [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #45282:
URL: https://github.com/apache/airflow/pull/45282#discussion_r1899434029
##########
task_sdk/tests/execution_time/test_task_runner.py:
##########
@@ -295,6 +295,47 @@ def test_run_raises_base_exception(time_machine, mocked_parse, make_ti_context):
)
+def test_run_raises_system_exit(time_machine, mocked_parse, make_ti_context):
+ """Test running a basic task that exits with SystemExit exception."""
+ from airflow.providers.standard.operators.python import PythonOperator
+
+ task = PythonOperator(
+ task_id="system_exit_task",
+ python_callable=lambda: exit(10),
+ )
+
+ what = StartupDetails(
+ ti=TaskInstance(
+ id=uuid7(),
+ task_id="system_exit_task",
+ dag_id="basic_dag_system_exit",
+ run_id="c",
+ try_number=1,
+ ),
+ file="",
+ requests_fd=0,
+ ti_context=make_ti_context(),
+ )
+
+ ti = mocked_parse(what, "basic_dag_system_exit", task)
+
+ instant = timezone.datetime(2024, 12, 3, 10, 0)
+ time_machine.move_to(instant, tick=False)
+
+ with mock.patch(
+ "airflow.sdk.execution_time.task_runner.SUPERVISOR_COMMS", create=True
+ ) as mock_supervisor_comms:
Review Comment:
Pushed in https://github.com/apache/airflow/pull/45282/commits/efbd3affe773f64d4ce0e00cd328241a30833810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-72: Handling SystemExit from task sdk [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #45282:
URL: https://github.com/apache/airflow/pull/45282#issuecomment-2565658200
Merging this, its a simple one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org