You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/17 15:07:54 UTC

[GitHub] [flink] tillrohrmann commented on a change in pull request #11109: [FLINK-15758][MemManager] Release segment and its unsafe memory in GC Cleaner

tillrohrmann commented on a change in pull request #11109: [FLINK-15758][MemManager] Release segment and its unsafe memory in GC Cleaner
URL: https://github.com/apache/flink/pull/11109#discussion_r410237975
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/core/memory/HybridMemorySegment.java
 ##########
 @@ -98,6 +104,8 @@
 	public ByteBuffer getOffHeapBuffer() {
 		if (offHeapBuffer != null) {
 			return offHeapBuffer;
+		} else if (address <= addressLimit) {
 
 Review comment:
   ```suggestion
   		} else if (isFreed()) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services