You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/14 15:17:35 UTC

[GitHub] [apisix] membphis commented on a change in pull request #2063: change: add hostname label for metric `etcd_reachable`

membphis commented on a change in pull request #2063:
URL: https://github.com/apache/apisix/pull/2063#discussion_r470688687



##########
File path: apisix/plugins/prometheus/exporter.lua
##########
@@ -76,7 +76,8 @@ function _M.init()
             {"state"})
 
     metrics.etcd_reachable = prometheus:gauge("etcd_reachable",
-            "Config server etcd reachable from APISIX, 0 is unreachable")
+            "Config server etcd reachable from APISIX, 0 is unreachable",
+            {"hostname"})

Review comment:
       we'd better use a new `metric` like `node_info`.
   store the `hostname` in `etcd_reachable`, it makes me confused.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org