[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6268: Persist part of configurations to registry center

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #6268:
URL: https://github.com/apache/shardingsphere/pull/6268#discussion_r449848119



##########
File path: shardingsphere-control-panel/shardingsphere-orchestration/shardingsphere-orchestration-core/shardingsphere-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java
##########
@@ -98,29 +98,19 @@ public void persistGlobalConfiguration(final Authentication authentication, fina
     }
     
     private void persistDataSourceConfiguration(final String shardingSchemaName, final Map<String, DataSourceConfiguration> dataSourceConfigurations, final boolean isOverwrite) {
-        if (isOverwrite || !hasDataSourceConfiguration(shardingSchemaName)) {
+        if (isOverwrite) {

Review comment:
       @wgy8283335 
   Hi, could you give it a check? Why did you prefer persisting the configuration for the first time even though `isOverwrite == false`?
   Do you think the change here could not cover all the scenarios?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org