[GitHub] [iceberg] rdblue commented on a change in pull request #4102: AWS: make DynamoDbLockManager public

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #4102:
URL: https://github.com/apache/iceberg/pull/4102#discussion_r805404589



##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/DynamoLockManager.java
##########
@@ -60,8 +60,9 @@
 import software.amazon.awssdk.services.dynamodb.model.TransactionConflictException;
 
 /**
- * DynamoDB implementation for the lock manager.
+ * @deprecated will be removed in 0.15.0, please use {@link org.apache.iceberg.aws.dynamodb.DynamoDbLockManager}
  */
+@Deprecated
 class DynamoLockManager extends LockManagers.BaseLockManager {

Review comment:
       Why deprecate this if it wasn't public in the first place?
   
   Also, can this extend `DynamoDbLockManager` so that we don't have two implementations? Then we can also get rid of the tests here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org