You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/12 08:29:14 UTC
[GitHub] [incubator-doris] qidaye opened a new pull request #7105: [BUG] fix profile not working with sql_cache enabled
qidaye opened a new pull request #7105:
URL: https://github.com/apache/incubator-doris/pull/7105
## Proposed changes
fix #7104.
When sql cache is hit, the profile is like this:
```
Query:
Summary:
- Query ID: 550eb34b2f5541ef-9bfe252bb4c88841
- Start Time: 2021-11-12 15:58:06
- End Time: 2021-11-12 15:58:06
- Total: 4ms
- Query Type: Query
- Query State: EOF
- Doris Version: trunk
- User: root
- Default Db: default_cluster:example_db
- Sql Statement: select c3, sum(c4) from (select c1, c2, c3, c4 from tb_test_1 where c1 = 1)a where c2=3 group by c3
- Is Cached: Yes
Execution Summary:
- Analysis Time: 1.344ms
- Plan Time: 1.84ms
- Schedule Time: N/A
- Wait and Fetch Result Time: N/A
Execution Profile 550eb34b2f5541ef-9bfe252bb4c88841:(Active: 4.946ms, % non-child: 100.00%)
Fragment 0:
```
**Note**: `Is Cached: Yes`.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #7104 ) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7105: [BUG] fix profile not working with sql_cache enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7105:
URL: https://github.com/apache/incubator-doris/pull/7105#issuecomment-966989808
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7105: [BUG] fix profile not working with sql_cache enabled
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #7105:
URL: https://github.com/apache/incubator-doris/pull/7105#discussion_r748141166
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
##########
@@ -749,9 +749,13 @@ private void handleCacheStmt(CacheAnalyzer cacheAnalyzer, MysqlChannel channel,
InternalService.PFetchCacheResult cacheResult = cacheAnalyzer.getCacheData();
CacheMode mode = cacheAnalyzer.getCacheMode();
SelectStmt newSelectStmt = selectStmt;
+
+ coord = new Coordinator(context, analyzer, planner);
boolean isSendFields = false;
if (cacheResult != null) {
isCached = true;
+ // Initialize coordinator, for query profile
+ coord.prepare();
Review comment:
It's better to prepare query profile only instead of whole coord.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 merged pull request #7105: [BUG] fix profile not working with sql_cache enabled
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged pull request #7105:
URL: https://github.com/apache/incubator-doris/pull/7105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7105: [BUG] fix profile not working with sql_cache enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7105:
URL: https://github.com/apache/incubator-doris/pull/7105#issuecomment-969830587
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #7105: [BUG] fix profile not working with sql_cache enabled
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #7105:
URL: https://github.com/apache/incubator-doris/pull/7105#issuecomment-966996971
You'd better to init cache profile and does not rely on coordinator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org