[Bug 62262] New: Drop "Use Keep-Alive" option altogether

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62262

            Bug ID: 62262
           Summary: Drop "Use Keep-Alive" option altogether
           Product: JMeter
           Version: 4.0
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: HTTP
          Assignee: issues@jmeter.apache.org
          Reporter: 1983-01-06@gmx.net
  Target Milestone: ---

JMeter 4.0 sports HttpClient 4.5.x and Java URLConnection by default. Both use
HTTP/1.1 only, one cannot control this in JMeter anyway (for the good). Having
the option "Use Keep-Alive" makes no sense. HTTP/1.1 is persistent by default.
Infact, "Connection: Keep-Alive" is an invalid header field for HTTP/1.1.
Closing is a performance penalty for client and server which is the default in
a new test plan.

I see no benefit to have this option around at all anymore. For those who want
to fiddle with connections can use a header manager for "Connection: close". 

The enhancement request to remove this altogether from GUI and code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 62262] Drop "Use Keep-Alive" option altogether

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62262

--- Comment #1 from UbikLoadPack support <su...@ubikloadpack.com> ---
Maybe it should be renamed and inversed to "Don't reuse connection".
In HC4 and Java impelementation, if it's true, then "Connection: close" would
be added so that it's easier for newbies.

Also in jmeter.properties, the below property should be documented to mention
it only related to AJP:

# Set the http version (defaults to 1.1)
# Only used by AjpSampler
httpclient.version=1.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 62262] Drop "Use Keep-Alive" option altogether

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62262

--- Comment #2 from Michael Osipov <19...@gmx.net> ---
(In reply to UbikLoadPack support from comment #1)
> Maybe it should be renamed and inversed to "Don't reuse connection".
> In HC4 and Java impelementation, if it's true, then "Connection: close"
> would be added so that it's easier for newbies.

That would make sense, but would still be a little deceiving because if
hc.paramters is change for 1.0 there wouldn't be a way to add "Connection:
Keep-Alive" for HTTP/1.0 explicitly unless the header manager is used. Note
that this isn't a valid 1.1 header. So, for sanity, I'd drop it altogether to
avoid such issues.

> Also in jmeter.properties, the below property should be documented to
> mention it only related to AJP:
> 
> # Set the http version (defaults to 1.1)
> # Only used by AjpSampler
> httpclient.version=1.1

Likely, but I rather drop that code block to be consistent with the
HTTPSampler. This version 4.0 after all. One can still use 2.x or 3.x for
ancient stuff.

-- 
You are receiving this mail because:
You are the assignee for the bug.