You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/16 06:34:33 UTC
Review Request 39375: Windows: Introduced socket flag interop.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39375/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
POSIX has a bunch of flags like `SHUT_SD` which let you do things like
specify (e.g.) how a socket shuts down. Windows has equivalents for many
of these flags as well, but they have different names.
So that we can avoid changing any of the socket code, we alias the flags
we know we need with their POSIX names.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 50e35f43d87c69a83a9e7d039d1881404ea8be38
Diff: https://reviews.apache.org/r/39375/diff/
Testing
-------
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39375: Windows: Introduced socket flag interop.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39375/#review102970
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Oct. 15, 2015, 9:34 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39375/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 9:34 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> POSIX has a bunch of flags like `SHUT_SD` which let you do things like
> specify (e.g.) how a socket shuts down. Windows has equivalents for many
> of these flags as well, but they have different names.
>
> So that we can avoid changing any of the socket code, we alias the flags
> we know we need with their POSIX names.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 50e35f43d87c69a83a9e7d039d1881404ea8be38
>
> Diff: https://reviews.apache.org/r/39375/diff/
>
>
> Testing
> -------
>
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
>
> Autotools `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39375: Windows: Introduced socket flag interop.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39375/#review103272
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 83)
<https://reviews.apache.org/r/39375/#comment161263>
Can this be a constexpr?
- Joris Van Remoortere
On Oct. 19, 2015, 11:25 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39375/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 11:25 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> POSIX has a bunch of flags like `SHUT_SD` which let you do things like
> specify (e.g.) how a socket shuts down. Windows has equivalents for many
> of these flags as well, but they have different names.
>
> So that we can avoid changing any of the socket code, we alias the flags
> we know we need with their POSIX names.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 4a0761f4bdd6a881429cb25d0a5f6e445da405cb
>
> Diff: https://reviews.apache.org/r/39375/diff/
>
>
> Testing
> -------
>
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
>
> Autotools `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39375: Windows: Introduced socket flag interop.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39375/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 11:25 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
POSIX has a bunch of flags like `SHUT_SD` which let you do things like
specify (e.g.) how a socket shuts down. Windows has equivalents for many
of these flags as well, but they have different names.
So that we can avoid changing any of the socket code, we alias the flags
we know we need with their POSIX names.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 4a0761f4bdd6a881429cb25d0a5f6e445da405cb
Diff: https://reviews.apache.org/r/39375/diff/
Testing
-------
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39375: Windows: Introduced socket flag interop.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39375/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 9:19 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
POSIX has a bunch of flags like `SHUT_SD` which let you do things like
specify (e.g.) how a socket shuts down. Windows has equivalents for many
of these flags as well, but they have different names.
So that we can avoid changing any of the socket code, we alias the flags
we know we need with their POSIX names.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 4a0761f4bdd6a881429cb25d0a5f6e445da405cb
Diff: https://reviews.apache.org/r/39375/diff/
Testing
-------
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39375: Windows: Introduced socket flag interop.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39375/
-----------------------------------------------------------
(Updated Oct. 16, 2015, 7:50 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
POSIX has a bunch of flags like `SHUT_SD` which let you do things like
specify (e.g.) how a socket shuts down. Windows has equivalents for many
of these flags as well, but they have different names.
So that we can avoid changing any of the socket code, we alias the flags
we know we need with their POSIX names.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 50e35f43d87c69a83a9e7d039d1881404ea8be38
Diff: https://reviews.apache.org/r/39375/diff/
Testing
-------
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer