[jira] [Resolved] (THRIFT-2986) Audit Cocoa library to address architecture-ignorant byte-swapping

["James E. King III (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James E. King III resolved THRIFT-2986.
---------------------------------------
       Resolution: Won't Do
         Assignee: James E. King III
    Fix Version/s: 1.0

As support for the older cocoa compiler and library have been removed (see THRIFT-4719), all of the issues in Jira related to that code have also been removed.  For legacy cocoa support you can use version 0.12.0 - everyone is expected to move to swift if they want to use the next release of Thrift.

> Audit Cocoa library to address architecture-ignorant byte-swapping
> ------------------------------------------------------------------
>
>                 Key: THRIFT-2986
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2986
>             Project: Thrift
>          Issue Type: Task
>          Components: Cocoa - Library
>    Affects Versions: 0.9.2
>            Reporter: Jeremy W. Sherman
>            Assignee: James E. King III
>            Priority: Major
>             Fix For: 1.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> This happens at least in TFramedTransport, where -flush manually swaps the length. Except, on a big-endian platform, it just swapped it from network byte order.
> For 32-bit values, {{htonl()}} will suffice, though the CFSwap… or NSSwap… families might be a better choice depending on the types in play.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)