Bug in NameRecord.java of HSSF

[John Lloyd <ll...@us.ibm.com>]

All,
While processing an Excel file (available upon request) with HSSF, I got a
run-time exception in the method NameRecord.fillFields(). I looked at the
code and found a bug in line 658 of that method in the file NameRecord.java
in version 1.10.0. The code should be adding the length of the previous
variable length field to find the start of the current field. Instead it is
adding the length of the current field. I changed the line as below to
solve the problem. How do I get this change into the HSSF base?

          //int start_of_description_text   = start_of_custom_menu_text +
field_8_length_description_text;
          int start_of_description_text   = start_of_custom_menu_text +
field_7_length_custom_menu;

John

Email  * lloydj@us.ibm.com
Phone  * 919-254-8021
Snail  * MZDA/062, IBM Corp., P.O. Box 12195, RTP, NC 27709-2195

Re: Bug in NameRecord.java of HSSF

[Danny Mui <da...@muibros.com>]

http://jakarta.apache.org/poi/getinvolved/index.html

label the summary with [PATCH] for more attention.  also adding/updating 
unit tests would speed along the commit as well since the unit test will 
ensure this bug will not get reintroduced.



John Lloyd wrote:

>All,
>While processing an Excel file (available upon request) with HSSF, I got a
>run-time exception in the method NameRecord.fillFields(). I looked at the
>code and found a bug in line 658 of that method in the file NameRecord.java
>in version 1.10.0. The code should be adding the length of the previous
>variable length field to find the start of the current field. Instead it is
>adding the length of the current field. I changed the line as below to
>solve the problem. How do I get this change into the HSSF base?
>
>          //int start_of_description_text   = start_of_custom_menu_text +
>field_8_length_description_text;
>          int start_of_description_text   = start_of_custom_menu_text +
>field_7_length_custom_menu;
>
>John
>
>Email  * lloydj@us.ibm.com
>Phone  * 919-254-8021
>Snail  * MZDA/062, IBM Corp., P.O. Box 12195, RTP, NC 27709-2195
>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: poi-dev-help@jakarta.apache.org
>
>  
>