You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/02/12 02:24:25 UTC

[GitHub] [incubator-seatunnel] simon824 commented on a change in pull request #1141: [Bug] [transform] Recover unequal code transform in FakeStream

simon824 commented on a change in pull request #1141:
URL: https://github.com/apache/incubator-seatunnel/pull/1141#discussion_r805104727



##########
File path: seatunnel-connectors/seatunnel-connector-spark-fake/src/main/scala/org/apache/seatunnel/spark/source/FakeStream.scala
##########
@@ -56,7 +56,11 @@ class FakeStream extends SparkStreamingSource[String] {
   }
 
   override def checkConfig(): CheckResult = {
-    checkAllExists(config, "content")
+    if (config.hasPath("content") && config.getStringList("content").nonEmpty) {
+      CheckResult.success()

Review comment:
       Actually, this problem exist in many other connectors, it's unnecessary to fix all connectors `checkConfig` one by one.  
   #1214 this pr has fix similar problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org