You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sergeyuttsel (via GitHub)" <gi...@apache.org> on 2023/05/17 11:16:47 UTC

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2077: IGNITE-19255 Some tests from DistributionZoneManagerScaleUpTest were fixed and enabled.

sergeyuttsel commented on code in PR #2077:
URL: https://github.com/apache/ignite-3/pull/2077#discussion_r1196333937


##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -95,8 +93,6 @@ void testDataNodesPropagationAfterScaleUpTriggered() throws Exception {
 
         Set<LogicalNode> clusterNodes = Set.of(NODE_1);
 
-        mockVaultZonesLogicalTopologyKey(clusterNodes);

Review Comment:
   Because no need to initialized logicalTopology with the same value from the `topology` and from the vault. So I decided to remove excessive mocking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org