You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by lifove <gi...@git.apache.org> on 2016/12/19 01:42:45 UTC
[GitHub] incubator-eagle pull request #751: [EAGLE-844] Fix a potential NPE
GitHub user lifove opened a pull request:
https://github.com/apache/incubator-eagle/pull/751
[EAGLE-844] Fix a potential NPE
<!--
{% comment %}
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to you under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
{% endcomment %}
-->
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[EAGLE-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lifove/incubator-eagle master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/751.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #751
----
commit dc73f0e92d9c617d562105c0353ecb3714c87f27
Author: JC <jc...@lifove.net>
Date: 2016-12-19T01:36:10Z
[EAGLE-844] Fix potential NPE
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #751: [EAGLE-844] Fix a potential NPE
Posted by RalphSu <gi...@git.apache.org>.
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/751#discussion_r92959638
--- Diff: eagle-core/eagle-query/eagle-storage-hbase/src/main/java/org/apache/eagle/storage/hbase/HBaseEntitySchemaManager.java ---
@@ -65,7 +65,7 @@ public void init() {
try {
admin = new HBaseAdmin(conf);
Map<String, EntityDefinition> entityServiceMap = EntityDefinitionManager.entities();
- if (entityServiceMap != null || entityServiceMap.values() != null) {
+ if (entityServiceMap != null && entityServiceMap.values() != null) {
--- End diff --
do we still need to check "entityServiceMap.values() != null"? it should not return null
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #751: [EAGLE-844] Fix a potential NPE
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/751
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #751: [EAGLE-844] Fix a potential NPE
Posted by wujinhu <gi...@git.apache.org>.
Github user wujinhu commented on the issue:
https://github.com/apache/incubator-eagle/pull/751
LGTM, will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #751: [EAGLE-844] Fix a potential NPE
Posted by lifove <gi...@git.apache.org>.
Github user lifove commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/751#discussion_r93083865
--- Diff: eagle-core/eagle-query/eagle-storage-hbase/src/main/java/org/apache/eagle/storage/hbase/HBaseEntitySchemaManager.java ---
@@ -65,7 +65,7 @@ public void init() {
try {
admin = new HBaseAdmin(conf);
Map<String, EntityDefinition> entityServiceMap = EntityDefinitionManager.entities();
- if (entityServiceMap != null || entityServiceMap.values() != null) {
+ if (entityServiceMap != null && entityServiceMap.values() != null) {
--- End diff --
Right. It shouldn't. will update soon. Thanks~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---