[jira] [Commented] (HBASE-4008) Problem while stopping HBase

["Akash Ashok (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087246#comment-13087246 ] 

Akash Ashok commented on HBASE-4008:
------------------------------------

Making it protected works for me. Because it isn't used by anything else currently. But I am thinking making it protected means only the class or the subclasses or the classes in the same package is able to call this method. So it means we are intending this method to be used only by subclasses or within same package. Just like isStopped() or isActiveMaster() even isAborted() has the potential to be called from somehwere outside the package. So based on how it could be called it could still be public. I would love to hear your thoughts on this. 

> Problem while stopping HBase
> ----------------------------
>
>                 Key: HBASE-4008
>                 URL: https://issues.apache.org/jira/browse/HBASE-4008
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Akash Ashok
>            Assignee: Akash Ashok
>              Labels: HMaster
>             Fix For: 0.92.0
>
>         Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly. 
> When u Run 
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run 
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira