You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ijuma (via GitHub)" <gi...@apache.org> on 2023/02/23 14:08:36 UTC

[GitHub] [kafka] ijuma commented on a diff in pull request #13205: KAFKA-14680: Upgrade gradle version from 7.6 to 8.0.1

ijuma commented on code in PR #13205:
URL: https://github.com/apache/kafka/pull/13205#discussion_r1115748575


##########
gradlew:
##########
@@ -32,10 +32,10 @@
 #       Busybox and similar reduced shells will NOT work, because this script
 #       requires all of these POSIX shell features:
 #         * functions;
-#         * expansions «$var», «${var}», «${var:-default}», «${var+SET}»,
-#           «${var#prefix}», «${var%suffix}», and «$( cmd )»;
-#         * compound commands having a testable exit status, especially «case»;
-#         * various built-in commands including «command», «set», and «ulimit».
+#         * expansions �$var�, �${var}�, �${var:-default}�, �${var+SET}�,
+#           �${var#prefix}�, �${var%suffix}�, and �$( cmd )�;
+#         * compound commands having a testable exit status, especially �case�;
+#         * various built-in commands including �command�, �set�, and �ulimit�.

Review Comment:
   Something weird happened here. When I run `./gradlew wrapper on my computer, it generates the following diff:
   
   ![image](https://user-images.githubusercontent.com/24747/220931022-f29cda04-957b-4f91-adea-05a0946415d4.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org