You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/02 22:36:07 UTC

[GitHub] [beam] rosetn commented on a change in pull request #12953: Minor programming guide improvements

rosetn commented on a change in pull request #12953:
URL: https://github.com/apache/beam/pull/12953#discussion_r499071428



##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -3554,7 +3554,7 @@ Now, consider the same pipeline, but using a windowing function:
 
 **Figure 5:** `GroupByKey` and `ParDo` with windowing, on a bounded collection.
 
-As before, the pipeline creates a bounded `PCollection` of key/value pairs. We
+As before, the pipeline creates a bounded `PCollection` of file lines. We

Review comment:
       I'd replace "of file lines" with "by reading lines from a file using `TextIO`." I think how you have it earlier is clear.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org