You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/20 13:53:07 UTC

[GitHub] leventov commented on a change in pull request #6349: maintenance mode for Historical

leventov commented on a change in pull request #6349: maintenance mode for Historical
URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r258489833
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/coordinator/rules/BroadcastDistributionRule.java
 ##########
 @@ -46,8 +46,9 @@ public CoordinatorStats run(DruidCoordinator coordinator, DruidCoordinatorRuntim
     } else {
       params.getDruidCluster().getAllServers().forEach(
           eachHolder -> {
-            if (colocatedDataSources.stream()
-                                    .anyMatch(source -> eachHolder.getServer().getDataSource(source) != null)) {
+            if (!eachHolder.isInMaintenance()
 
 Review comment:
   Shouldn't this `!eachHolder.isInMaintenance()` condition be in an outer `if`, rather than in this if-else chain? As it is written, if a node in the maintenance mode, the coordinator will delete segments from it rather than leave the node alone.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org