Re: [PR] fix schedule_downstream_tasks bug [airflow]

["luoyuliuyin (via GitHub)" <gi...@apache.org>]

luoyuliuyin commented on PR #42582:
URL: https://github.com/apache/airflow/pull/42582#issuecomment-2404646732

   Adding `include_upstream=True` is still unsafe. Here is a bad case where `task_one_success` is ignored again. Given that `partial_subset` has little impact on performance, I recommend removing `partial_subset` completely.
   
   ![image](https://github.com/user-attachments/assets/67fceabc-3270-48c3-ab25-9b046e0a0bc2)
   task => "task_0"
   task.downstream_task_ids => "task_1"
   
   include_downstream=True => ["task_1", "task_2"]
   include_upstream=True =>["task_0", "task_1", "task_2"]
   include_direct_upstream=True => ["task_0", "task_1", "task_2", "task_one_success", "task_skip"]
   
   So the final partial_dag is ["task_0", "task_1", "task_2", "task_one_success", "task_skip"]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org