You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/20 04:18:10 UTC
[GitHub] [incubator-kyuubi] Nick-0723 opened a new pull request #2182: [KYUUBI #2086] Add issue template for subtasks
Nick-0723 opened a new pull request #2182:
URL: https://github.com/apache/incubator-kyuubi/pull/2182
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
Add issue template for subtasks
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on a change in pull request #2182: [KYUUBI #2086] Add issue template for subtasks
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on a change in pull request #2182:
URL: https://github.com/apache/incubator-kyuubi/pull/2182#discussion_r830564537
##########
File path: .github/ISSUE_TEMPLATE/subtask.yml
##########
@@ -0,0 +1,71 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Subtask
+title: "[Subtask] "
+description: A subtask issue
+labels: [ "kind:subtask" ]
+body:
+
+ - type: checkboxes
+ attributes:
+ label: Code of Conduct
+ description: The Code of Conduct helps create a safe space for everyone. We require that everyone agrees to it.
+ options:
+ - label: >
+ I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
+ required: true
+
+ - type: checkboxes
+ attributes:
+ label: Search before asking
+ options:
+ - label: >
+ I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues) and found no similar
+ issues.
+ required: true
+
+ - type: checkboxes
+ attributes:
+ label: Search before asking
+ options:
+ - label: >
+ I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues) and found no similar
+ issues.
+ required: true
+
+ - type: textarea
+ attributes:
+ label: Parent issue
+ placeholder: >
+ Please put the parent issue link here.
+ validations:
+ required: true
+
Review comment:
done, plz review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on pull request #2182: [KYUUBI #2086] Add issue template for subtasks
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on pull request #2182:
URL: https://github.com/apache/incubator-kyuubi/pull/2182#issuecomment-1073179863
> https://github.com/apache/incubator-kyuubi/blob/master/.github/ISSUE_TEMPLATE/subtask.yml there are syntax errors, can you make a follow-up to fix them?
oops, I get it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2182: [KYUUBI #2086] Add issue template for subtasks
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #2182:
URL: https://github.com/apache/incubator-kyuubi/pull/2182#issuecomment-1073178386
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #2182: [KYUUBI #2086] Add issue template for subtasks
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #2182:
URL: https://github.com/apache/incubator-kyuubi/pull/2182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2182: [KYUUBI #2086] Add issue template for subtasks
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2182:
URL: https://github.com/apache/incubator-kyuubi/pull/2182#issuecomment-1073175328
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2182](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7aec23d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/f29adb2f3b382f06ace653d9d196e9640971a1eb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f29adb2) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2182 +/- ##
============================================
- Coverage 61.48% 61.47% -0.02%
Complexity 69 69
============================================
Files 327 327
Lines 15659 15659
Branches 2005 2005
============================================
- Hits 9628 9626 -2
- Misses 5213 5214 +1
- Partials 818 819 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-2.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f29adb2...7aec23d](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2182: [KYUUBI #2086] Add issue template for subtasks
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2182:
URL: https://github.com/apache/incubator-kyuubi/pull/2182#issuecomment-1073175328
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2182](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7aec23d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/f29adb2f3b382f06ace653d9d196e9640971a1eb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f29adb2) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7aec23d differs from pull request most recent head 545c0c7. Consider uploading reports for the commit 545c0c7 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2182 +/- ##
============================================
- Coverage 61.48% 61.47% -0.02%
Complexity 69 69
============================================
Files 327 327
Lines 15659 15659
Branches 2005 2005
============================================
- Hits 9628 9626 -2
- Misses 5213 5214 +1
- Partials 818 819 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-2.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f29adb2...545c0c7](https://codecov.io/gh/apache/incubator-kyuubi/pull/2182?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2182: [KYUUBI #2086] Add issue template for subtasks
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #2182:
URL: https://github.com/apache/incubator-kyuubi/pull/2182#issuecomment-1073179509
https://github.com/apache/incubator-kyuubi/blob/master/.github/ISSUE_TEMPLATE/subtask.yml there are syntax errors, can you make a follow-up to fix them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2182: [KYUUBI #2086] Add issue template for subtasks
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2182:
URL: https://github.com/apache/incubator-kyuubi/pull/2182#discussion_r830564089
##########
File path: .github/ISSUE_TEMPLATE/subtask.yml
##########
@@ -0,0 +1,71 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Subtask
+title: "[Subtask] "
+description: A subtask issue
+labels: [ "kind:subtask" ]
+body:
+
+ - type: checkboxes
+ attributes:
+ label: Code of Conduct
+ description: The Code of Conduct helps create a safe space for everyone. We require that everyone agrees to it.
+ options:
+ - label: >
+ I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
+ required: true
+
+ - type: checkboxes
+ attributes:
+ label: Search before asking
+ options:
+ - label: >
+ I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues) and found no similar
+ issues.
+ required: true
+
+ - type: checkboxes
+ attributes:
+ label: Search before asking
+ options:
+ - label: >
+ I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues) and found no similar
+ issues.
+ required: true
+
+ - type: textarea
+ attributes:
+ label: Parent issue
+ placeholder: >
+ Please put the parent issue link here.
+ validations:
+ required: true
+
Review comment:
we need a textarea for description of the subtask
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org