You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/02 22:09:13 UTC
[kudu-CR] Fix compile error in sasl server.cc
Hello Dan Burkert, Sailesh Mukil,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4920
to review the following change.
Change subject: Fix compile error in sasl_server.cc
......................................................................
Fix compile error in sasl_server.cc
Sailesh's recent patch and my recent patch had a semantic conflict which
didn't get caught in precommit. This patch has the trivial fix.
Change-Id: If5958981956bb23fa5f34f9ef89b88e8f07f4a81
---
M src/kudu/rpc/sasl_server.cc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/4920/1
--
To view, visit http://gerrit.cloudera.org:8080/4920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5958981956bb23fa5f34f9ef89b88e8f07f4a81
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[kudu-CR] Fix compile error in sasl server.cc
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix compile error in sasl_server.cc
......................................................................
Patch Set 1: Code-Review+2 Verified+1
This passed the build stage of jenkins so I'll call it +1 and push
--
To view, visit http://gerrit.cloudera.org:8080/4920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5958981956bb23fa5f34f9ef89b88e8f07f4a81
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix compile error in sasl server.cc
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix compile error in sasl_server.cc
......................................................................
Fix compile error in sasl_server.cc
Sailesh's recent patch and my recent patch had a semantic conflict which
didn't get caught in precommit. This patch has the trivial fix.
Change-Id: If5958981956bb23fa5f34f9ef89b88e8f07f4a81
Reviewed-on: http://gerrit.cloudera.org:8080/4920
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/rpc/sasl_server.cc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/4920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5958981956bb23fa5f34f9ef89b88e8f07f4a81
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>