You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "aditya87 (GitHub)" <gi...@apache.org> on 2018/11/19 23:49:20 UTC

[GitHub] [geode] aditya87 commented on pull request #2875: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

I agree that the RegionConfigFactory should be in the command directory -- we will move that. With regards to the RegionFunctionArgs -- yes, we should ideally not use it, but we wanted to do this in the most incremental fashion possible. The most important takeaway here is moving away from generating XML snippets to persist, and also using SingleGfshCommand and ResultModel. Eventually we will get rid of RegionFunctionArgs.

[ Full content available at: https://github.com/apache/geode/pull/2875 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org