You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by "Petr Pisl (Jira)" <ji...@apache.org> on 2022/03/22 15:23:00 UTC

[jira] [Closed] (NETBEANS-4826) Groovy completion tests fail when JavaIndexer reference in Groovy layer is fixed.

     [ https://issues.apache.org/jira/browse/NETBEANS-4826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Petr Pisl closed NETBEANS-4826.
-------------------------------
    Fix Version/s: 12.0.2
       Resolution: Fixed

Fixed together with this this PR: [https://github.com/apache/netbeans/pull/3802/]

The PR contains also other fixes of these problems:
 * static fields and methods are offered as fields and methods in import statements code completion - they were previously offered as classes in code completion.
 * correcting types of constructors that are strored in Groovy Index
 * JavaElementHandles now are created with the fully qualifed names, there were created only with simple names.
 * adding [@trusted|https://github.com/trusted] annotation for ForwardingJavaFileObject implementations

> Groovy completion tests fail when JavaIndexer reference in Groovy layer is fixed.
> ---------------------------------------------------------------------------------
>
>                 Key: NETBEANS-4826
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-4826
>             Project: NetBeans
>          Issue Type: Bug
>          Components: groovy - Editor
>            Reporter: Svatopluk Dedic
>            Assignee: Petr Pisl
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 12.0.2
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> For reference see [PR-2359|https://github.com/apache/netbeans/pull/2359]. The JavaIndexer .shadow file is broken (fails commit-validation task), but when fixed, tests in Groovy editor fail. Possibly the tests need to be updated appropriately.
> I've removed (commented out) the indexer, as it was ineffective for years, but the change should be reviewed / fixed by someone knowledgeable in Groovy code.
> Setting as major, as having / not having Java indexer may have quite an impact on the project's symbols.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists