You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/11/13 16:35:03 UTC
[GitHub] mistercrunch commented on issue #3852: fix input height to match with react-select
mistercrunch commented on issue #3852: fix input height to match with react-select
URL: https://github.com/apache/incubator-superset/pull/3852#issuecomment-343976978
I think that will create other problems like what's here being addressed here (inconsistent sizing between buttons and form controls):
https://github.com/apache/incubator-superset/pull/3850
The notion of `bsSize="small"` is consistent across bootstrap (control input, buttons, ...). We've been using `bsSize="small"` pretty much everywhere too.
If we want react-select to match the size of form inputs, we should either create a small react-select, or move to not using `bsSize="small"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services