[jira] [Commented] (LUCENE-10183) KnnVectorsWriter#writeField should take a KnnVectorsReader, not a VectorValues instance

["Zach Chen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457534#comment-17457534 ] 

Zach Chen commented on LUCENE-10183:
------------------------------------

Hi [~jpountz] , I've opened a PR for this issue. Please let me know if looks good to you.

> KnnVectorsWriter#writeField should take a KnnVectorsReader, not a VectorValues instance
> ---------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10183
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10183
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> By taking a VectorValues instance, KnnVectorsWriter#write doesn't let implementations iterate over vectors multiple times if needed. It should take a KnnVectorReaders similarly to doc values, where the writer takes a DocValuesProducer.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org