You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/02 10:15:29 UTC
[GitHub] larroy commented on a change in pull request #10951: [MXNET-545]
Fix broken cython build
larroy commented on a change in pull request #10951: [MXNET-545] Fix broken cython build
URL: https://github.com/apache/incubator-mxnet/pull/10951#discussion_r207171408
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -33,6 +33,18 @@ clean_repo() {
git submodule update --init --recursive
}
+check_cython() {
+ set -ex
+ local python_ver=$1
+ if [ "$(echo -e 'import mxnet as mx\nprint(mx.nd._internal.NDArrayBase.__module__)' | python${python_ver})" != "mxnet._cy${python_ver}.ndarray" ]; then
Review comment:
can we use python -c and move it before the conditional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services