You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2018/08/13 20:10:46 UTC
[GitHub] michael-o commented on a change in pull request #84: sonar: fix
possible NPE, same fix of svn/git provider
michael-o commented on a change in pull request #84: sonar: fix possible NPE, same fix of svn/git provider
URL: https://github.com/apache/maven-scm/pull/84#discussion_r209741948
##########
File path: maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/BazaarScmProvider.java
##########
@@ -81,7 +81,12 @@ public ScmProviderRepository makeProviderScmRepository( String scmSpecificUrl, c
public ScmProviderRepository makeProviderScmRepository( File path )
throws ScmRepositoryException, UnknownRepositoryStructure
{
- if ( path == null || !path.isDirectory() )
+ if ( path == null )
+ {
+ throw new NullPointerException( "Path argument is null" );
Review comment:
Please say "path cannot be null".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services