You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by gr...@apache.org on 2016/10/11 07:18:00 UTC
[1/3] git commit: [flex-asjs] [refs/heads/develop] - [Tests] Fixed
test for SWF,
and added back the failing js release-mode test. This failing test should
remain until it is either a) no longer apparent or b) becomes 'expected' for
JS via documentation.
Repository: flex-asjs
Updated Branches:
refs/heads/develop e118e31d8 -> b7f661c75
[Tests] Fixed test for SWF, and added back the failing js release-mode test.
This failing test should remain until it is either a) no longer apparent or b) becomes 'expected' for JS via documentation.
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/4262fbe7
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/4262fbe7
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/4262fbe7
Branch: refs/heads/develop
Commit: 4262fbe7e882825927c7ab4a39efe8cc283bb72e
Parents: 93797c2
Author: greg-dove <gr...@gmail.com>
Authored: Tue Oct 11 18:23:53 2016 +1300
Committer: greg-dove <gr...@gmail.com>
Committed: Tue Oct 11 18:23:53 2016 +1300
----------------------------------------------------------------------
.../observedbugs/ObservedBugTests.as | 23 ++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/4262fbe7/manualtests/GenericTests/src/flexUnitTests/observedbugs/ObservedBugTests.as
----------------------------------------------------------------------
diff --git a/manualtests/GenericTests/src/flexUnitTests/observedbugs/ObservedBugTests.as b/manualtests/GenericTests/src/flexUnitTests/observedbugs/ObservedBugTests.as
index 4590c7b..46887ac 100644
--- a/manualtests/GenericTests/src/flexUnitTests/observedbugs/ObservedBugTests.as
+++ b/manualtests/GenericTests/src/flexUnitTests/observedbugs/ObservedBugTests.as
@@ -59,24 +59,39 @@ package flexUnitTests.observedbugs
}
- [TestVariance(variance="JS",description="Variance in test, this test fails in JS-Release mode only")]
[Test]
- public function testTryCatchJSReleaseModeFail():void
+ public function testTryCatchJSReleaseModeWorks_a():void
{
var js:int = 1;
try {
- js = getDefinitionByName("flash.system.Capabilities") == null ? 1 : 0;
+ js = getDefinitionByName("flash.system.Capabilities") != null ? 1 : 0;
} catch (e:Error) {
js = 2;
}
+ Assert.assertTrue("Unexpected value following try/catch",(isJS ? (js == 2) : (js == 1));
+
+ }
+
+
+ [TestVariance(variance="JS",description="Variance in test, this test fails in JS-Release mode only")]
+ [Test]
+ public function testTryCatchJSReleaseModeFails_b():void
+ {
+ var js:Boolean = false;
+ try {
+ var check:* = getDefinitionByName("flash.system.Capabilities");
+ } catch (e:Error) {
+ js = true;
+ }
+
//if this next reference to 'check' variable is not included, then the above try/catch code
// appears to be optimized away in js-release mode
//todo: this is inconsistent with swf
/* if (check == null) {
js = true;
}*/
- Assert.assertTrue("Unexpected value following try/catch",(isJS ? (js == 2) : (js == 1));
+ Assert.assertTrue("Unexpected value following try/catch",(isJS ? (js == true) : (js == false));
}
[2/3] git commit: [flex-asjs] [refs/heads/develop] - [Tests] Added
extra check for static initialization to DataBindingTestbed
Posted by gr...@apache.org.
[Tests] Added extra check for static initialization to DataBindingTestbed
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/6ecf8916
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/6ecf8916
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/6ecf8916
Branch: refs/heads/develop
Commit: 6ecf8916c12837db431e5ffaa69e3d32efdef0c9
Parents: 4262fbe
Author: greg-dove <gr...@gmail.com>
Authored: Tue Oct 11 18:25:36 2016 +1300
Committer: greg-dove <gr...@gmail.com>
Committed: Tue Oct 11 18:25:36 2016 +1300
----------------------------------------------------------------------
.../DataBindingTestbed/src/MyInitialView.mxml | 19 ++++++++
.../bindables/BindableWithConstructorInit.as | 46 ++++++++++++++++++++
2 files changed, 65 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/6ecf8916/manualtests/DataBindingTestbed/src/MyInitialView.mxml
----------------------------------------------------------------------
diff --git a/manualtests/DataBindingTestbed/src/MyInitialView.mxml b/manualtests/DataBindingTestbed/src/MyInitialView.mxml
index 3f788fe..67d5ac7 100644
--- a/manualtests/DataBindingTestbed/src/MyInitialView.mxml
+++ b/manualtests/DataBindingTestbed/src/MyInitialView.mxml
@@ -174,6 +174,25 @@ limitations under the License.
addErrorReport("problem with explicit dispatching from BindableSubVO3 ",e);
}
+ test=null;
+ try {
+ test = BindableWithConstructorInit.STATIC_INIT;
+ if (test.value !="STATIC_INIT") {
+ throw new Error("problem with static init in BindableWithConstructorInit ");
+ }
+ test.value= "STATIC_INIT_CHANGED";
+ } catch (e:Error) {
+ addErrorReport("problem with static init in BindableWithConstructorInit ",e);
+ }
+
+ test=null;
+ try {
+ test = new BindableWithConstructorInit("string",99)
+ } catch (e:Error) {
+ addErrorReport("problem instantiating BindableWithConstructorInit ",e);
+ }
+
+
}
private var _expectedTarget:Object;
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/6ecf8916/manualtests/DataBindingTestbed/src/bindables/BindableWithConstructorInit.as
----------------------------------------------------------------------
diff --git a/manualtests/DataBindingTestbed/src/bindables/BindableWithConstructorInit.as b/manualtests/DataBindingTestbed/src/bindables/BindableWithConstructorInit.as
new file mode 100644
index 0000000..b150bd3
--- /dev/null
+++ b/manualtests/DataBindingTestbed/src/bindables/BindableWithConstructorInit.as
@@ -0,0 +1,46 @@
+////////////////////////////////////////////////////////////////////////////////
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+package bindables
+{
+
+
+ [Bindable]
+ public class BindableWithConstructorInit
+ {
+
+ public static const STATIC_INIT:BindableWithConstructorInit = new BindableWithConstructorInit( "STATIC_INIT" ,-1 );
+
+ public var ordinal:int;
+ public var value:String;
+
+ public function BindableWithConstructorInit ( value:String, ordinal:int )
+ {
+ this.value = value;
+ this.ordinal = ordinal;
+ }
+
+
+
+ public function equals( other:BindableWithConstructorInit ):Boolean
+ {
+ return ( this.ordinal == other.ordinal && this.value == other.value );
+ }
+ }
+
+}
\ No newline at end of file
[3/3] git commit: [flex-asjs] [refs/heads/develop] - Merge branch
'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop
Posted by gr...@apache.org.
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/b7f661c7
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/b7f661c7
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/b7f661c7
Branch: refs/heads/develop
Commit: b7f661c75b3616e0fff5daddcb19f67a41ec2e63
Parents: 6ecf891 e118e31
Author: greg-dove <gr...@gmail.com>
Authored: Tue Oct 11 18:25:56 2016 +1300
Committer: greg-dove <gr...@gmail.com>
Committed: Tue Oct 11 18:25:56 2016 +1300
----------------------------------------------------------------------
.../apache/flex/html/beads/DateChooserView.as | 61 ++++++++++++++++----
1 file changed, 50 insertions(+), 11 deletions(-)
----------------------------------------------------------------------